mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
c21458a15d
If the Buffer object's length is zero, or equal to the underlying
buffer object's length, `parent` property returns `undefined`.
> new Buffer(0).parent
undefined
> new Buffer(Buffer.poolSize).parent
undefined
This patch makes the buffer objects to consistently expose the buffer
object via the `parent` property, always.
Fixes: https://github.com/nodejs/node/issues/8266
PR-URL: https://github.com/nodejs/node/pull/8311
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
24 lines
862 B
JavaScript
24 lines
862 B
JavaScript
'use strict';
|
|
|
|
/*
|
|
* Fix for https://github.com/nodejs/node/issues/8266
|
|
*
|
|
* Zero length Buffer objects should expose the `buffer` property of the
|
|
* TypedArrays, via the `parent` property.
|
|
*/
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
// If the length of the buffer object is zero
|
|
assert((new Buffer(0)).parent instanceof ArrayBuffer);
|
|
|
|
// If the length of the buffer object is equal to the underlying ArrayBuffer
|
|
assert((new Buffer(Buffer.poolSize)).parent instanceof ArrayBuffer);
|
|
|
|
// Same as the previous test, but with user created buffer
|
|
const arrayBuffer = new ArrayBuffer(0);
|
|
assert.strictEqual(new Buffer(arrayBuffer).parent, arrayBuffer);
|
|
assert.strictEqual(new Buffer(arrayBuffer).buffer, arrayBuffer);
|
|
assert.strictEqual(Buffer.from(arrayBuffer).parent, arrayBuffer);
|
|
assert.strictEqual(Buffer.from(arrayBuffer).buffer, arrayBuffer);
|