mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
36b2e25b4a
This makes sure all usages of `util.debuglog()` must contain the string 'test' as argument. PR-URL: https://github.com/nodejs/node/pull/32161 Refs: https://github.com/nodejs/node/pull/32078 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
72 lines
4.6 KiB
YAML
72 lines
4.6 KiB
YAML
## Test-specific linter rules
|
|
|
|
env:
|
|
node: true
|
|
es6: true
|
|
|
|
rules:
|
|
# ECMAScript 6
|
|
# http://eslint.org/docs/rules/#ecmascript-6
|
|
no-var: error
|
|
prefer-const: error
|
|
symbol-description: off
|
|
|
|
no-restricted-syntax:
|
|
# Config copied from .eslintrc.js
|
|
- error
|
|
- selector: "CallExpression:matches([callee.name='deepStrictEqual'], [callee.property.name='deepStrictEqual'])[arguments.2.type='Literal']"
|
|
message: "Do not use a literal for the third argument of assert.deepStrictEqual()"
|
|
- selector: "CallExpression:matches([callee.name='doesNotThrow'], [callee.property.name='doesNotThrow'])"
|
|
message: "Do not use `assert.doesNotThrow()`. Write the code without the wrapper and add a comment instead."
|
|
- selector: "CallExpression:matches([callee.name='doesNotReject'], [callee.property.name='doesNotReject'])"
|
|
message: "Do not use `assert.doesNotReject()`. Write the code without the wrapper and add a comment instead."
|
|
- selector: "CallExpression:matches([callee.name='rejects'], [callee.property.name='rejects'])[arguments.length<2]"
|
|
message: "`assert.rejects()` must be invoked with at least two arguments."
|
|
- selector: "CallExpression[callee.property.name='strictEqual'][arguments.2.type='Literal']"
|
|
message: "Do not use a literal for the third argument of assert.strictEqual()"
|
|
- selector: "CallExpression:matches([callee.name='throws'], [callee.property.name='throws'])[arguments.1.type='Literal']:not([arguments.1.regex])"
|
|
message: "Use an object as second argument of `assert.throws()`."
|
|
- selector: "CallExpression:matches([callee.name='throws'], [callee.property.name='throws'])[arguments.length<2]"
|
|
message: "`assert.throws()` must be invoked with at least two arguments."
|
|
- selector: "CallExpression[callee.name='setTimeout'][arguments.length<2]"
|
|
message: "`setTimeout()` must be invoked with at least two arguments."
|
|
- selector: "CallExpression[callee.name='setInterval'][arguments.length<2]"
|
|
message: "`setInterval()` must be invoked with at least two arguments."
|
|
- selector: "ThrowStatement > CallExpression[callee.name=/Error$/]"
|
|
message: "Use `new` keyword when throwing an `Error`."
|
|
- selector: "CallExpression:matches([callee.name='notDeepStrictEqual'], [callee.property.name='notDeepStrictEqual'])[arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])"
|
|
message: "The first argument should be the `actual`, not the `expected` value."
|
|
- selector: "CallExpression:matches([callee.name='notStrictEqual'], [callee.property.name='notStrictEqual'])[arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])"
|
|
message: "The first argument should be the `actual`, not the `expected` value."
|
|
- selector: "CallExpression:matches([callee.name='deepStrictEqual'], [callee.property.name='deepStrictEqual'])[arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])"
|
|
message: "The first argument should be the `actual`, not the `expected` value."
|
|
- selector: "CallExpression:matches([callee.name='strictEqual'], [callee.property.name='strictEqual'])[arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])"
|
|
message: "The first argument should be the `actual`, not the `expected` value."
|
|
- selector: "CallExpression[callee.name='isNaN']"
|
|
message: "Use Number.isNaN() instead of the global isNaN() function."
|
|
- selector: "VariableDeclarator > CallExpression:matches([callee.name='debuglog'], [callee.property.name='debuglog']):not([arguments.0.value='test'])"
|
|
message: "Use 'test' as debuglog value in tests."
|
|
|
|
# Custom rules in tools/eslint-rules
|
|
node-core/prefer-assert-iferror: error
|
|
node-core/prefer-assert-methods: error
|
|
node-core/prefer-common-mustnotcall: error
|
|
node-core/crypto-check: error
|
|
node-core/eslint-check: error
|
|
node-core/inspector-check: error
|
|
## common module is mandatory in tests
|
|
node-core/required-modules:
|
|
- error
|
|
- common: 'common(/index\.(m)?js)?$'
|
|
node-core/require-common-first: error
|
|
node-core/no-duplicate-requires: off
|
|
|
|
# Global scoped methods and vars
|
|
globals:
|
|
WebAssembly: false
|
|
BigInt: false
|
|
BigInt64Array: false
|
|
BigUint64Array: false
|
|
SharedArrayBuffer: false
|
|
globalThis: false
|