mirrors/nodejs
mirrors/nodejs
0
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-30 07:27:22 +01:00
Code Issues Releases Activity
b4f745ec5a
nodejs/test
History
Anna Henningsen 1046816875
worker: move JoinThread() back into exit callback 
de2c68c7dd moved this call to
the destructor, under the assumption that that would essentially
be equivalent to running it as part of the callback since the
worker would be destroyed along with the callback.

However, the actual code in
`Environment::RunAndClearNativeImmediates()` comes with the subtlety
that testing whether a JS exception has been thrown
happens between the invocation of the callback and its destruction,
leaving a possible exception from `JoinThread()` potentially
unhandled (and unintentionally silenced through the `TryCatch`).

This affected exceptions thrown from the `'exit'` event of the
Worker, and made the `parallel/test-worker-message-type-unknown`
test flaky, as the invalid message was sometimes only received
during the Worker thread’s exit handler.

Fix this by moving the `JoinThread()` call back to where it was
before.

Refs: https://github.com/nodejs/node/pull/31386

PR-URL: https://github.com/nodejs/node/pull/31468
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
2020-01-23 02:59:39 +01:00
..
abort
addons test: export public symbols in addons tests 2020-01-17 18:51:50 -08:00
async-hooks async_hooks: remove internal only error checking 2020-01-11 19:20:45 -08:00
benchmark benchmark: add benchmark on async_hooks enabled http server 2020-01-02 17:51:19 +01:00
cctest src: remove uses of node::InitializeV8Platform() 2020-01-09 16:50:25 +01:00
common report: add support for Workers 2020-01-21 23:51:38 +01:00
doctool tools: update JSON header parsing for backticks 2020-01-12 07:10:33 -08:00
es-module module: unflag conditional exports 2020-01-15 20:48:52 -05:00
fixtures test,module: add test for exports cjs loader check 2020-01-20 21:33:07 -08:00
internet
js-native-api n-api: return napi_invalid_arg on napi_create_bigint_words 2020-01-13 21:16:05 -08:00
known_issues
message module: loader getSource, getFormat, transform hooks 2020-01-07 01:31:05 +02:00
node-api n-api: keep napi_env alive while it has finalizers 2020-01-04 07:38:36 +01:00
parallel worker: move JoinThread() back into exit callback 2020-01-23 02:59:39 +01:00
pseudo-tty
pummel
report report: add support for Workers 2020-01-21 23:51:38 +01:00
sequential
testpy
tick-processor
tools
v8-updates test: update postmortem test with v12 constants 2020-01-18 15:43:00 -08:00
wasi test: improve wasi stat test 2020-01-21 13:23:54 -08:00
wpt
.eslintrc.yaml lib,tools,test: remove custom number-isnan rule 2020-01-08 00:22:25 -05:00
README.md
root.status lib,tools,test: remove custom number-isnan rule 2020-01-08 00:22:25 -05:00

README.md

Node.js Core Tests

This directory contains code and data used to test the Node.js implementation.

For a detailed guide on how to write tests in this directory, see the guide on writing tests.

On how to run tests in this directory, see the contributing guide.

For the tests to run on Windows, be sure to clone Node.js source code with the autocrlf git config flag set to true.

Test Directories

Directory Runs on CI Purpose
abort Yes Tests for when the --abort-on-uncaught-exception flag is used.
addons Yes Tests for addon functionality along with some tests that require an addon.
async-hooks Yes Tests for async_hooks functionality.
benchmark No Test minimal functionality of benchmarks.
cctest Yes C++ tests that are run as part of the build process.
code-cache No Tests for a Node.js binary compiled with V8 code cache.
common Common modules shared among many tests. Documentation
doctool Yes Tests for the documentation generator.
es-module Yes Test ESM module loading.
fixtures Test fixtures used in various tests throughout the test suite.
internet No Tests that make real outbound network connections. Tests for networking related modules may also be present in other directories, but those tests do not make outbound connections.
js-native-api Yes Tests for Node.js-agnostic n-api functionality.
known_issues Yes Tests reproducing known issues within the system. All tests inside of this directory are expected to fail. If a test doesn't fail on certain platforms, those should be skipped via known_issues.status.
message Yes Tests for messages that are output for various conditions (console.log, error messages etc.)
node-api Yes Tests for Node.js-specific n-api functionality.
parallel Yes Various tests that are able to be run in parallel.
pseudo-tty Yes Tests that require stdin/stdout/stderr to be a TTY.
pummel No Various tests for various modules / system functionality operating under load.
sequential Yes Various tests that must not run in parallel.
testpy Test configuration utility used by various test suites.
tick-processor No Tests for the V8 tick processor integration. The tests are for the logic in lib/internal/v8_prof_processor.js and lib/internal/v8_prof_polyfill.js. The tests confirm that the profile processor packages the correct set of scripts from V8 and introduces the correct platform specific logic.
v8-updates No Tests for V8 performance integration.