mirror of
https://github.com/nodejs/node.git
synced 2024-11-24 20:29:23 +01:00
05db68245b
`check-imports.py` was missing some unused `using` statements as it was not matching on word boundaries (e.g. `MaybeLocal` was considered a use of `Local`). Fix that and add some unit tests (which required the script to be renamed to drop the `-` so it could be imported into the test script). PR-URL: https://github.com/nodejs/node/pull/33268 Refs: https://github.com/nodejs/node/issues/29226 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
78 lines
2.7 KiB
Python
78 lines
2.7 KiB
Python
import unittest
|
|
import sys
|
|
from contextlib import contextmanager
|
|
from os import path
|
|
sys.path.append(path.abspath(path.join(path.dirname(__file__),
|
|
'..', '..', 'tools')))
|
|
try:
|
|
from StringIO import StringIO
|
|
except ImportError:
|
|
from io import StringIO
|
|
|
|
from checkimports import is_valid
|
|
|
|
@contextmanager
|
|
def captured_output():
|
|
tmp_out, tmp_err = StringIO(), StringIO()
|
|
old_out, old_err = sys.stdout, sys.stderr
|
|
try:
|
|
sys.stdout, sys.stderr = tmp_out, tmp_err
|
|
yield sys.stdout, sys.stderr
|
|
finally:
|
|
sys.stdout, sys.stderr = old_out, old_err
|
|
tmp_out.close()
|
|
tmp_err.close()
|
|
|
|
class CheckImportsTest(unittest.TestCase):
|
|
fixturesDir = path.join(path.dirname(__file__), '..', '..',
|
|
'test', 'fixtures', 'tools', 'checkimports')
|
|
|
|
def test_unused_and_unsorted(self):
|
|
with captured_output() as (out, err):
|
|
self.assertEqual(is_valid(path.join(self.fixturesDir, 'invalid.cc')),
|
|
False)
|
|
output = out.getvalue()
|
|
self.assertIn('does not use "Local"', output);
|
|
self.assertIn('using statements aren\'t sorted in', output);
|
|
self.assertIn('Line 1: Actual: v8::MaybeLocal, Expected: v8::Array',
|
|
output);
|
|
self.assertIn('Line 2: Actual: v8::Array, Expected: v8::Local',
|
|
output);
|
|
self.assertIn('Line 3: Actual: v8::Local, Expected: v8::MaybeLocal',
|
|
output);
|
|
|
|
def test_unused_complex(self):
|
|
with captured_output() as (out, err):
|
|
self.assertEqual(is_valid(path.join(self.fixturesDir, 'maybe.cc')),
|
|
False)
|
|
output = out.getvalue()
|
|
self.assertIn('does not use "Local"', output);
|
|
|
|
def test_unused_simple(self):
|
|
with captured_output() as (out, err):
|
|
self.assertEqual(is_valid(path.join(self.fixturesDir, 'unused.cc')),
|
|
False)
|
|
output = out.getvalue()
|
|
self.assertIn('does not use "Context"', output);
|
|
|
|
def test_unsorted(self):
|
|
with captured_output() as (out, err):
|
|
self.assertEqual(is_valid(path.join(self.fixturesDir, 'unsorted.cc')),
|
|
False)
|
|
output = out.getvalue()
|
|
self.assertIn('using statements aren\'t sorted in', output);
|
|
self.assertIn('Line 1: Actual: v8::MaybeLocal, Expected: v8::Array',
|
|
output);
|
|
self.assertIn('Line 2: Actual: v8::Array, Expected: v8::MaybeLocal',
|
|
output);
|
|
|
|
def test_valid(self):
|
|
with captured_output() as (out, err):
|
|
self.assertEqual(is_valid(path.join(self.fixturesDir, 'valid.cc')),
|
|
True)
|
|
output = out.getvalue()
|
|
self.assertEqual(output, '');
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main()
|