nodejs/pseudo-tty.status at a84c3be07593755e1ab91bb3714b549ebdf60f9b - nodejs - Smart Yellow Git

mirrors/nodejs

mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00

Gireesh Punathil d631af59c0

test: delay child exit in AIX for pseudo-tty tests

The tests in pseudo-tty takes the form of child node writing some data
and exiting, while parent python consume them through pseudo tty
implementations, and validate the result.

While there is no synchronization between child and parent, this works
for most platforms, except AIX, where the child exits even before the
parent could setup the read loop, under race conditions

Fixing the race condition is ideally done through sending ACK messages
to and forth, but involves massive changes and have side effect. The
workaround is to address them in AIX alone, by adding a reasonable
delay.

PR-URL: https://github.com/nodejs/node/pull/11715
Fixes: https://github.com/nodejs/node/issues/7973
Fixes: https://github.com/nodejs/node/issues/9765
Fixes: https://github.com/nodejs/node/issues/11541
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

2017-03-17 12:28:44 +00:00

6 lines

144 B

Plaintext

Raw Blame History

 prefix pseudo-tty
 [$system==aix]
 # being investigated under https://github.com/nodejs/node/issues/9728
 test-tty-wrap              : FAIL, PASS