0
0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
nodejs/tools/gyp
Daniel Bevenius 9fd22bc4d4 build: fix ninja build failure (GYP patch)
Currently the files specified in libraries in node.gyp `cctest` target are
getting a '.lib' extension on windows when generated with ninja.
This commit adds a check to see if a file has a '.obj' extension and in
that case no '.lib' extension will be added.

Also, the LIBS specified in the 'libraries' section are not
being included in the --start-group --end-group section which
means that these libraries will not be searched causing issue
with linkers where the order matters.

PR-URL: https://github.com/nodejs/node/pull/12484
Fixes: https://github.com/nodejs/node/issues/12448
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
2017-05-11 08:12:24 -04:00
..
buildbot
data/win
pylib/gyp build: fix ninja build failure (GYP patch) 2017-05-11 08:12:24 -04:00
samples
tools tools: update gyp to eb296f6 2017-04-18 13:22:28 -04:00
.gitignore
AUTHORS tools: update gyp to eb296f6 2017-04-18 13:22:28 -04:00
codereview.settings tools: update gyp to eb296f6 2017-04-18 13:22:28 -04:00
DEPS tools: update gyp to eb296f6 2017-04-18 13:22:28 -04:00
gyp
gyp_main.py
gyp.bat
gyptest.py tools: update gyp to eb296f6 2017-04-18 13:22:28 -04:00
LICENSE
OWNERS
PRESUBMIT.py tools: update gyp to eb296f6 2017-04-18 13:22:28 -04:00
README.md tools: update gyp to eb296f6 2017-04-18 13:22:28 -04:00
setup.py

GYP can Generate Your Projects.

Documents are available at gyp.gsrc.io, or you can check out md-pages branch to read those documents offline.