mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
2d7e31614d
Detect whether a gzip file is being passed to `unzip*` by testing the first bytes for the gzip magic bytes, and setting the decompression mode to `GUNZIP` or `INFLATE` according to the result. This enables gzip-only features like multi-member support to be used together with the `unzip*` autodetection support and thereby makes `gunzip*` and `unzip*` return identical results for gzip input again. Add a simple test for checking that features specific to `zlib.gunzip`, notably support for multiple members, also work when using `zlib.unzip`. PR-URL: https://github.com/nodejs/node/pull/5884 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
81 lines
2.5 KiB
JavaScript
81 lines
2.5 KiB
JavaScript
'use strict';
|
|
// Test unzipping a gzip file that contains multiple concatenated "members"
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const zlib = require('zlib');
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
|
|
const abcEncoded = zlib.gzipSync('abc');
|
|
const defEncoded = zlib.gzipSync('def');
|
|
|
|
const data = Buffer.concat([
|
|
abcEncoded,
|
|
defEncoded
|
|
]);
|
|
|
|
assert.equal(zlib.gunzipSync(data).toString(), 'abcdef');
|
|
|
|
zlib.gunzip(data, common.mustCall((err, result) => {
|
|
assert.ifError(err);
|
|
assert.equal(result, 'abcdef', 'result should match original string');
|
|
}));
|
|
|
|
zlib.unzip(data, common.mustCall((err, result) => {
|
|
assert.ifError(err);
|
|
assert.equal(result, 'abcdef', 'result should match original string');
|
|
}));
|
|
|
|
// Multi-member support does not apply to zlib inflate/deflate.
|
|
zlib.unzip(Buffer.concat([
|
|
zlib.deflateSync('abc'),
|
|
zlib.deflateSync('def')
|
|
]), common.mustCall((err, result) => {
|
|
assert.ifError(err);
|
|
assert.equal(result, 'abc', 'result should match contents of first "member"');
|
|
}));
|
|
|
|
// files that have the "right" magic bytes for starting a new gzip member
|
|
// in the middle of themselves, even if they are part of a single
|
|
// regularly compressed member
|
|
const pmmFileZlib = path.join(common.fixturesDir, 'pseudo-multimember-gzip.z');
|
|
const pmmFileGz = path.join(common.fixturesDir, 'pseudo-multimember-gzip.gz');
|
|
|
|
const pmmExpected = zlib.inflateSync(fs.readFileSync(pmmFileZlib));
|
|
const pmmResultBuffers = [];
|
|
|
|
fs.createReadStream(pmmFileGz)
|
|
.pipe(zlib.createGunzip())
|
|
.on('error', (err) => {
|
|
assert.ifError(err);
|
|
})
|
|
.on('data', (data) => pmmResultBuffers.push(data))
|
|
.on('finish', common.mustCall(() => {
|
|
assert.deepStrictEqual(Buffer.concat(pmmResultBuffers), pmmExpected,
|
|
'result should match original random garbage');
|
|
}));
|
|
|
|
// test that the next gzip member can wrap around the input buffer boundary
|
|
[0, 1, 2, 3, 4, defEncoded.length].forEach((offset) => {
|
|
const resultBuffers = [];
|
|
|
|
const unzip = zlib.createGunzip()
|
|
.on('error', (err) => {
|
|
assert.ifError(err);
|
|
})
|
|
.on('data', (data) => resultBuffers.push(data))
|
|
.on('finish', common.mustCall(() => {
|
|
assert.strictEqual(Buffer.concat(resultBuffers).toString(), 'abcdef',
|
|
`result should match original input (offset = ${offset})`);
|
|
}));
|
|
|
|
// first write: write "abc" + the first bytes of "def"
|
|
unzip.write(Buffer.concat([
|
|
abcEncoded, defEncoded.slice(0, offset)
|
|
]));
|
|
|
|
// write remaining bytes of "def"
|
|
unzip.end(defEncoded.slice(offset));
|
|
});
|