mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
21b0a27af8
This reverts commit 9359de9dd2.
Original Commit Message:
The "fs" module has two functions called `maybeCallback` and
`makeCallback`, as of now.
The `maybeCallback` creates a default function to report errors, if the
parameter passed is not a function object. Basically, if the callback
is omitted in some cases, this function is used to create a default
callback function.
The `makeCallback`, OTOH, creates a default function only if the
parameter passed is `undefined`, and if it is not a function object it
will throw an `Error`.
This patch removes the `maybeCallback` function and makes the callback
function argument mandatory for all the async functions.
PR-URL: https://github.com/nodejs/node/pull/7168
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/7846
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
82 lines
2.0 KiB
JavaScript
82 lines
2.0 KiB
JavaScript
/* eslint-disable strict */
|
|
const common = require('../common');
|
|
var assert = require('assert');
|
|
var fs = require('fs');
|
|
|
|
fs.stat('.', common.mustCall(function(err, stats) {
|
|
assert.ifError(err);
|
|
assert.ok(stats.mtime instanceof Date);
|
|
assert(this === global);
|
|
}));
|
|
|
|
fs.stat('.', common.mustCall(function(err, stats) {
|
|
assert.ok(stats.hasOwnProperty('blksize'));
|
|
assert.ok(stats.hasOwnProperty('blocks'));
|
|
}));
|
|
|
|
fs.lstat('.', common.mustCall(function(err, stats) {
|
|
assert.ifError(err);
|
|
assert.ok(stats.mtime instanceof Date);
|
|
assert(this === global);
|
|
}));
|
|
|
|
// fstat
|
|
fs.open('.', 'r', undefined, common.mustCall(function(err, fd) {
|
|
assert.ok(!err);
|
|
assert.ok(fd);
|
|
|
|
fs.fstat(fd, common.mustCall(function(err, stats) {
|
|
assert.ifError(err);
|
|
assert.ok(stats.mtime instanceof Date);
|
|
fs.close(fd);
|
|
assert(this === global);
|
|
}));
|
|
|
|
assert(this === global);
|
|
}));
|
|
|
|
// fstatSync
|
|
fs.open('.', 'r', undefined, common.mustCall(function(err, fd) {
|
|
var stats;
|
|
try {
|
|
stats = fs.fstatSync(fd);
|
|
} catch (err) {
|
|
common.fail(err);
|
|
}
|
|
if (stats) {
|
|
console.dir(stats);
|
|
assert.ok(stats.mtime instanceof Date);
|
|
}
|
|
fs.close(fd);
|
|
}));
|
|
|
|
console.log(`stating: ${__filename}`);
|
|
fs.stat(__filename, common.mustCall(function(err, s) {
|
|
assert.ifError(err);
|
|
|
|
console.dir(s);
|
|
|
|
console.log('isDirectory: ' + JSON.stringify(s.isDirectory()));
|
|
assert.equal(false, s.isDirectory());
|
|
|
|
console.log('isFile: ' + JSON.stringify(s.isFile()));
|
|
assert.equal(true, s.isFile());
|
|
|
|
console.log('isSocket: ' + JSON.stringify(s.isSocket()));
|
|
assert.equal(false, s.isSocket());
|
|
|
|
console.log('isBlockDevice: ' + JSON.stringify(s.isBlockDevice()));
|
|
assert.equal(false, s.isBlockDevice());
|
|
|
|
console.log('isCharacterDevice: ' + JSON.stringify(s.isCharacterDevice()));
|
|
assert.equal(false, s.isCharacterDevice());
|
|
|
|
console.log('isFIFO: ' + JSON.stringify(s.isFIFO()));
|
|
assert.equal(false, s.isFIFO());
|
|
|
|
console.log('isSymbolicLink: ' + JSON.stringify(s.isSymbolicLink()));
|
|
assert.equal(false, s.isSymbolicLink());
|
|
|
|
assert.ok(s.mtime instanceof Date);
|
|
}));
|