mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
56 lines
2.0 KiB
JavaScript
56 lines
2.0 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const child_process = require('child_process');
|
|
const assert = require('assert');
|
|
const { Worker, workerData } = require('worker_threads');
|
|
|
|
// Test for https://github.com/nodejs/node/issues/24947.
|
|
|
|
if (!workerData && process.argv[2] !== 'child') {
|
|
process.env.SET_IN_PARENT = 'set';
|
|
assert.strictEqual(process.env.SET_IN_PARENT, 'set');
|
|
|
|
new Worker(__filename, { workerData: 'runInWorker' })
|
|
.on('exit', common.mustCall(() => {
|
|
// Env vars from the child thread are not set globally.
|
|
assert.strictEqual(process.env.SET_IN_WORKER, undefined);
|
|
}));
|
|
|
|
process.env.SET_IN_PARENT_AFTER_CREATION = 'set';
|
|
|
|
new Worker(__filename, {
|
|
workerData: 'resetEnv',
|
|
env: { 'MANUALLY_SET': true }
|
|
});
|
|
|
|
assert.throws(() => {
|
|
new Worker(__filename, { env: 42 });
|
|
}, {
|
|
name: 'TypeError',
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: 'The "options.env" property must be of type object or ' +
|
|
'one of undefined, null, or worker_threads.SHARE_ENV. Received type ' +
|
|
'number (42)'
|
|
});
|
|
} else if (workerData === 'runInWorker') {
|
|
// Env vars from the parent thread are inherited.
|
|
assert.strictEqual(process.env.SET_IN_PARENT, 'set');
|
|
assert.strictEqual(process.env.SET_IN_PARENT_AFTER_CREATION, undefined);
|
|
process.env.SET_IN_WORKER = 'set';
|
|
assert.strictEqual(process.env.SET_IN_WORKER, 'set');
|
|
|
|
Object.defineProperty(process.env, 'DEFINED_IN_WORKER', { value: 42 });
|
|
assert.strictEqual(process.env.DEFINED_IN_WORKER, '42');
|
|
|
|
const { stderr } =
|
|
child_process.spawnSync(process.execPath, [__filename, 'child']);
|
|
assert.strictEqual(stderr.toString(), '', stderr.toString());
|
|
} else if (workerData === 'resetEnv') {
|
|
assert.deepStrictEqual(Object.keys(process.env), ['MANUALLY_SET']);
|
|
assert.strictEqual(process.env.MANUALLY_SET, 'true');
|
|
} else {
|
|
// Child processes inherit the parent's env, even from Workers.
|
|
assert.strictEqual(process.env.SET_IN_PARENT, 'set');
|
|
assert.strictEqual(process.env.SET_IN_WORKER, 'set');
|
|
}
|