mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
95 lines
2.2 KiB
JavaScript
95 lines
2.2 KiB
JavaScript
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const vm = require('vm');
|
|
|
|
const invalidArgType = {
|
|
name: 'TypeError',
|
|
code: 'ERR_INVALID_ARG_TYPE'
|
|
};
|
|
|
|
const outOfRange = {
|
|
name: 'RangeError',
|
|
code: 'ERR_OUT_OF_RANGE'
|
|
};
|
|
|
|
assert.throws(() => {
|
|
new vm.Script('void 0', 42);
|
|
}, invalidArgType);
|
|
|
|
[null, {}, [1], 'bad', true].forEach((value) => {
|
|
assert.throws(() => {
|
|
new vm.Script('void 0', { lineOffset: value });
|
|
}, invalidArgType);
|
|
|
|
assert.throws(() => {
|
|
new vm.Script('void 0', { columnOffset: value });
|
|
}, invalidArgType);
|
|
});
|
|
|
|
[0.1, 2 ** 32].forEach((value) => {
|
|
assert.throws(() => {
|
|
new vm.Script('void 0', { lineOffset: value });
|
|
}, outOfRange);
|
|
|
|
assert.throws(() => {
|
|
new vm.Script('void 0', { columnOffset: value });
|
|
}, outOfRange);
|
|
});
|
|
|
|
assert.throws(() => {
|
|
new vm.Script('void 0', { lineOffset: Number.MAX_SAFE_INTEGER });
|
|
}, outOfRange);
|
|
|
|
assert.throws(() => {
|
|
new vm.Script('void 0', { columnOffset: Number.MAX_SAFE_INTEGER });
|
|
}, outOfRange);
|
|
|
|
assert.throws(() => {
|
|
new vm.Script('void 0', { filename: 123 });
|
|
}, invalidArgType);
|
|
|
|
assert.throws(() => {
|
|
new vm.Script('void 0', { produceCachedData: 1 });
|
|
}, invalidArgType);
|
|
|
|
[[0], {}, true, 'bad', 42].forEach((value) => {
|
|
assert.throws(() => {
|
|
new vm.Script('void 0', { cachedData: value });
|
|
}, invalidArgType);
|
|
});
|
|
|
|
{
|
|
const script = new vm.Script('void 0');
|
|
const sandbox = vm.createContext();
|
|
|
|
function assertErrors(options, errCheck) {
|
|
assert.throws(() => {
|
|
script.runInThisContext(options);
|
|
}, errCheck);
|
|
|
|
assert.throws(() => {
|
|
script.runInContext(sandbox, options);
|
|
}, errCheck);
|
|
|
|
assert.throws(() => {
|
|
script.runInNewContext({}, options);
|
|
}, errCheck);
|
|
}
|
|
|
|
[null, 'bad', 42].forEach((value) => {
|
|
assertErrors(value, invalidArgType);
|
|
});
|
|
[{}, [1], 'bad', null].forEach((value) => {
|
|
assertErrors({ timeout: value }, invalidArgType);
|
|
});
|
|
[-1, 0, NaN].forEach((value) => {
|
|
assertErrors({ timeout: value }, outOfRange);
|
|
});
|
|
[{}, [1], 'bad', 1, null].forEach((value) => {
|
|
assertErrors({ displayErrors: value }, invalidArgType);
|
|
assertErrors({ breakOnSigint: value }, invalidArgType);
|
|
});
|
|
}
|