mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
54 lines
1.2 KiB
JavaScript
54 lines
1.2 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('internal/fs/utils');
|
|
|
|
// Valid encodings and no args should not throw.
|
|
fs.assertEncoding();
|
|
fs.assertEncoding('utf8');
|
|
|
|
assert.throws(
|
|
() => fs.assertEncoding('foo'),
|
|
{ code: 'ERR_INVALID_OPT_VALUE_ENCODING', name: 'TypeError' }
|
|
);
|
|
|
|
// Test junction symlinks
|
|
{
|
|
const pathString = 'c:\\test1';
|
|
const linkPathString = '\\test2';
|
|
|
|
const preprocessSymlinkDestination = fs.preprocessSymlinkDestination(
|
|
pathString,
|
|
'junction',
|
|
linkPathString
|
|
);
|
|
|
|
if (process.platform === 'win32') {
|
|
assert.strictEqual(/^\\\\\?\\/.test(preprocessSymlinkDestination), true);
|
|
} else {
|
|
assert.strictEqual(preprocessSymlinkDestination, pathString);
|
|
}
|
|
}
|
|
|
|
// Test none junction symlinks
|
|
{
|
|
const pathString = 'c:\\test1';
|
|
const linkPathString = '\\test2';
|
|
|
|
const preprocessSymlinkDestination = fs.preprocessSymlinkDestination(
|
|
pathString,
|
|
undefined,
|
|
linkPathString
|
|
);
|
|
|
|
if (process.platform === 'win32') {
|
|
// There should not be any forward slashes
|
|
assert.strictEqual(
|
|
/\//.test(preprocessSymlinkDestination), false);
|
|
} else {
|
|
assert.strictEqual(preprocessSymlinkDestination, pathString);
|
|
}
|
|
}
|