mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
48 lines
1.1 KiB
JavaScript
48 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
const { expectsError, mustCall } = require('../common');
|
|
|
|
// Test that the request socket is destroyed if the `'clientError'` event is
|
|
// emitted and there is no listener for it.
|
|
|
|
const assert = require('assert');
|
|
const { createServer } = require('http');
|
|
const { createConnection } = require('net');
|
|
|
|
const server = createServer();
|
|
|
|
server.on('connection', mustCall((socket) => {
|
|
socket.on('error', expectsError({
|
|
name: 'Error',
|
|
message: 'Parse Error: Invalid method encountered',
|
|
code: 'HPE_INVALID_METHOD',
|
|
bytesParsed: 0,
|
|
rawPacket: Buffer.from('FOO /\r\n')
|
|
}));
|
|
}));
|
|
|
|
server.listen(0, () => {
|
|
const chunks = [];
|
|
const socket = createConnection({
|
|
allowHalfOpen: true,
|
|
port: server.address().port
|
|
});
|
|
|
|
socket.on('connect', mustCall(() => {
|
|
socket.write('FOO /\r\n');
|
|
}));
|
|
|
|
socket.on('data', (chunk) => {
|
|
chunks.push(chunk);
|
|
});
|
|
|
|
socket.on('end', mustCall(() => {
|
|
const expected = Buffer.from(
|
|
'HTTP/1.1 400 Bad Request\r\nConnection: close\r\n\r\n'
|
|
);
|
|
assert(Buffer.concat(chunks).equals(expected));
|
|
|
|
server.close();
|
|
}));
|
|
});
|