mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
66 lines
2.0 KiB
JavaScript
66 lines
2.0 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const tmpdir = require('../common/tmpdir');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const { promises } = fs;
|
|
|
|
// Validate the path argument.
|
|
[false, 1, {}, [], null, undefined].forEach((i) => {
|
|
const err = { name: 'TypeError', code: 'ERR_INVALID_ARG_TYPE' };
|
|
|
|
assert.throws(() => fs.lchown(i, 1, 1, common.mustNotCall()), err);
|
|
assert.throws(() => fs.lchownSync(i, 1, 1), err);
|
|
promises.lchown(false, 1, 1)
|
|
.then(common.mustNotCall())
|
|
.catch(common.expectsError(err));
|
|
});
|
|
|
|
// Validate the uid and gid arguments.
|
|
[false, 'test', {}, [], null, undefined].forEach((i) => {
|
|
const err = { name: 'TypeError', code: 'ERR_INVALID_ARG_TYPE' };
|
|
|
|
assert.throws(
|
|
() => fs.lchown('not_a_file_that_exists', i, 1, common.mustNotCall()),
|
|
err
|
|
);
|
|
assert.throws(
|
|
() => fs.lchown('not_a_file_that_exists', 1, i, common.mustNotCall()),
|
|
err
|
|
);
|
|
assert.throws(() => fs.lchownSync('not_a_file_that_exists', i, 1), err);
|
|
assert.throws(() => fs.lchownSync('not_a_file_that_exists', 1, i), err);
|
|
|
|
promises.lchown('not_a_file_that_exists', i, 1)
|
|
.then(common.mustNotCall())
|
|
.catch(common.expectsError(err));
|
|
|
|
promises.lchown('not_a_file_that_exists', 1, i)
|
|
.then(common.mustNotCall())
|
|
.catch(common.expectsError(err));
|
|
});
|
|
|
|
// Validate the callback argument.
|
|
[false, 1, 'test', {}, [], null, undefined].forEach((i) => {
|
|
assert.throws(() => fs.lchown('not_a_file_that_exists', 1, 1, i), {
|
|
name: 'TypeError',
|
|
code: 'ERR_INVALID_CALLBACK'
|
|
});
|
|
});
|
|
|
|
if (!common.isWindows) {
|
|
const testFile = path.join(tmpdir.path, path.basename(__filename));
|
|
const uid = process.geteuid();
|
|
const gid = process.getegid();
|
|
|
|
tmpdir.refresh();
|
|
fs.copyFileSync(__filename, testFile);
|
|
fs.lchownSync(testFile, uid, gid);
|
|
fs.lchown(testFile, uid, gid, common.mustCall(async (err) => {
|
|
assert.ifError(err);
|
|
await promises.lchown(testFile, uid, gid);
|
|
}));
|
|
}
|