mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
101 lines
4.8 KiB
JavaScript
101 lines
4.8 KiB
JavaScript
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
const rangeBuffer = Buffer.from('abc');
|
|
|
|
// If start >= buffer's length, empty string will be returned
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 3), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', +Infinity), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 3.14, 3), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 'Infinity', 3), '');
|
|
|
|
// If end <= 0, empty string will be returned
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 1, 0), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 1, -1.2), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 1, -100), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 1, -Infinity), '');
|
|
|
|
// If start < 0, start will be taken as zero
|
|
assert.strictEqual(rangeBuffer.toString('ascii', -1, 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', -1.99, 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', -Infinity, 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '-1', 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '-1.99', 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '-Infinity', 3), 'abc');
|
|
|
|
// If start is an invalid integer, start will be taken as zero
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 'node.js', 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', {}, 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', [], 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', NaN, 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', null, 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', undefined, 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', false, 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '', 3), 'abc');
|
|
|
|
// But, if start is an integer when coerced, then it will be coerced and used.
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '-1', 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '1', 3), 'bc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '-Infinity', 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '3', 3), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', Number(3), 3), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '3.14', 3), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '1.99', 3), 'bc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', '-1.99', 3), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 1.99, 3), 'bc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', true, 3), 'bc');
|
|
|
|
// If end > buffer's length, end will be taken as buffer's length
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, 5), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, 6.99), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, Infinity), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '5'), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '6.99'), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, 'Infinity'), 'abc');
|
|
|
|
// If end is an invalid integer, end will be taken as buffer's length
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, 'node.js'), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, {}), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, NaN), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, undefined), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, null), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, []), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, false), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, ''), '');
|
|
|
|
// But, if end is an integer when coerced, then it will be coerced and used.
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '-1'), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '1'), 'a');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '-Infinity'), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '3'), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, Number(3)), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '3.14'), 'abc');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '1.99'), 'a');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, '-1.99'), '');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, 1.99), 'a');
|
|
assert.strictEqual(rangeBuffer.toString('ascii', 0, true), 'a');
|
|
|
|
// Try toString() with an object as an encoding
|
|
assert.strictEqual(rangeBuffer.toString({ toString: function() {
|
|
return 'ascii';
|
|
} }), 'abc');
|
|
|
|
// Try toString() with 0 and null as the encoding
|
|
assert.throws(() => {
|
|
rangeBuffer.toString(0, 1, 2);
|
|
}, {
|
|
code: 'ERR_UNKNOWN_ENCODING',
|
|
name: 'TypeError',
|
|
message: 'Unknown encoding: 0'
|
|
});
|
|
assert.throws(() => {
|
|
rangeBuffer.toString(null, 1, 2);
|
|
}, {
|
|
code: 'ERR_UNKNOWN_ENCODING',
|
|
name: 'TypeError',
|
|
message: 'Unknown encoding: null'
|
|
});
|