mirror of
https://github.com/nodejs/node.git
synced 2024-11-29 23:16:30 +01:00
9e4660b518
This commit fixes the Node process crashing when constructors of classes
of the zlib module are given invalid options.
* Throw an Error when the zlib library rejects the value of windowBits,
instead of crashing with an assertion.
* Treat windowBits and memLevel options consistently with other ones and
don't crash when non-numeric values are given.
* Fix bugs in the validation logic:
- Don't conflate 0 and undefined when checking if a field of an
options object exists.
- Treat NaN and Infinity values the same way as values of invalid
types instead of allowing to actually set zlib options to NaN or
Infinity.
PR-URL: https://github.com/nodejs/node/pull/13098
Fixes: https://github.com/nodejs/node/issues/13082
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
|
||
|---|---|---|
| .. | ||
| api | ||
| api_assets | ||
| changelogs | ||
| guides | ||
| .eslintrc.yaml | ||
| full-white-stripe.jpg | ||
| node.1 | ||
| onboarding-extras.md | ||
| onboarding.md | ||
| osx_installer_logo.png | ||
| releases.md | ||
| STYLE_GUIDE.md | ||
| template.html | ||
| thin-white-stripe.jpg | ||
