mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
48 lines
1.1 KiB
JavaScript
48 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
|
|
if (!common.isMainThread)
|
|
common.skip('process.chdir is not available in Workers');
|
|
|
|
const { writeHeapSnapshot, getHeapSnapshot } = require('v8');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const tmpdir = require('../common/tmpdir');
|
|
|
|
tmpdir.refresh();
|
|
process.chdir(tmpdir.path);
|
|
|
|
{
|
|
writeHeapSnapshot('my.heapdump');
|
|
fs.accessSync('my.heapdump');
|
|
}
|
|
|
|
{
|
|
const heapdump = writeHeapSnapshot();
|
|
assert.strictEqual(typeof heapdump, 'string');
|
|
fs.accessSync(heapdump);
|
|
}
|
|
|
|
[1, true, {}, [], null, Infinity, NaN].forEach((i) => {
|
|
assert.throws(() => writeHeapSnapshot(i), {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "path" argument must be of type string or an instance of ' +
|
|
'Buffer or URL.' +
|
|
common.invalidArgTypeHelper(i)
|
|
});
|
|
});
|
|
|
|
{
|
|
let data = '';
|
|
const snapshot = getHeapSnapshot();
|
|
snapshot.setEncoding('utf-8');
|
|
snapshot.on('data', common.mustCallAtLeast((chunk) => {
|
|
data += chunk.toString();
|
|
}));
|
|
snapshot.on('end', common.mustCall(() => {
|
|
JSON.parse(data);
|
|
}));
|
|
}
|