mirror of
https://github.com/nodejs/node.git
synced 2024-11-29 23:16:30 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
101 lines
2.8 KiB
JavaScript
101 lines
2.8 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const nodeModules = path.join(__dirname, 'node_modules');
|
|
const nestedNodeModules = path.join(__dirname, 'node_modules', 'node_modules');
|
|
const nestedIndex = path.join(__dirname, 'nested-index');
|
|
|
|
// Test the default behavior.
|
|
assert.strictEqual(
|
|
require.resolve('bar'),
|
|
path.join(nodeModules, 'bar.js')
|
|
);
|
|
|
|
// Verify that existing paths are removed.
|
|
assert.throws(() => {
|
|
require.resolve('bar', { paths: [] })
|
|
}, /^Error: Cannot find module 'bar'/);
|
|
|
|
// Verify that resolution path can be overwritten.
|
|
{
|
|
// three.js cannot be loaded from this file by default.
|
|
assert.throws(() => {
|
|
require.resolve('three')
|
|
}, /^Error: Cannot find module 'three'/);
|
|
|
|
// If the nested-index directory is provided as a resolve path, 'three'
|
|
// cannot be found because nested-index is used as a starting point and not
|
|
// a searched directory.
|
|
assert.throws(() => {
|
|
require.resolve('three', { paths: [nestedIndex] })
|
|
}, /^Error: Cannot find module 'three'/);
|
|
|
|
// Resolution from nested index directory also checks node_modules.
|
|
assert.strictEqual(
|
|
require.resolve('bar', { paths: [nestedIndex] }),
|
|
path.join(nodeModules, 'bar.js')
|
|
);
|
|
}
|
|
|
|
// Verify that the default paths can be used and modified.
|
|
{
|
|
const paths = require.resolve.paths('bar');
|
|
|
|
assert.strictEqual(paths[0], nodeModules);
|
|
assert.strictEqual(
|
|
require.resolve('bar', { paths }),
|
|
path.join(nodeModules, 'bar.js')
|
|
);
|
|
|
|
paths.unshift(nestedNodeModules);
|
|
assert.strictEqual(
|
|
require.resolve('bar', { paths }),
|
|
path.join(nodeModules, 'bar.js')
|
|
);
|
|
}
|
|
|
|
// Verify that relative request paths work properly.
|
|
{
|
|
const searchIn = './' + path.relative(process.cwd(), nestedIndex);
|
|
|
|
// Search in relative paths.
|
|
assert.strictEqual(
|
|
require.resolve('./three.js', { paths: [searchIn] }),
|
|
path.join(nestedIndex, 'three.js')
|
|
);
|
|
|
|
// Search in absolute paths.
|
|
assert.strictEqual(
|
|
require.resolve('./three.js', { paths: [nestedIndex] }),
|
|
path.join(nestedIndex, 'three.js')
|
|
);
|
|
|
|
// Repeat the same tests with Windows slashes in the request path.
|
|
if (common.isWindows) {
|
|
assert.strictEqual(
|
|
require.resolve('.\\three.js', { paths: [searchIn] }),
|
|
path.join(nestedIndex, 'three.js')
|
|
);
|
|
|
|
assert.strictEqual(
|
|
require.resolve('.\\three.js', { paths: [nestedIndex] }),
|
|
path.join(nestedIndex, 'three.js')
|
|
);
|
|
}
|
|
}
|
|
|
|
// Test paths option validation
|
|
assert.throws(() => {
|
|
require.resolve('.\\three.js', { paths: 'foo' })
|
|
}, {
|
|
code: 'ERR_INVALID_OPT_VALUE',
|
|
name: 'TypeError',
|
|
});
|
|
|
|
// Verify that the default require.resolve() is used for empty options.
|
|
assert.strictEqual(
|
|
require.resolve('./printA.js', {}),
|
|
require.resolve('./printA.js')
|
|
);
|