mirror of
https://github.com/nodejs/node.git
synced 2024-11-29 23:16:30 +01:00
5cd9d76b02
Add two, admittedly contrived, examples that test edge cases of the vm module. They demonstrate that the if statements `if (maybe_rv.IsEmpty())` and `if (maybe_prop_attr.IsNothing())` in the GetterCallback and the QueryCallback are observable. Both GetterCallback and QueryCallback explicitly check the global_proxy() if a property is not found on the sandbox. In these tests, the explicit check inside the callback yields different results than deferring the check until after the callback. The check is deferred, if the callbacks do not intercept, i.e., if args.GetReturnValue().Set() is not called. PR-URL: https://github.com/nodejs/node/pull/11265 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> |
||
---|---|---|
.. | ||
known_issues.status | ||
test-module-deleted-extensions.js | ||
test-path-parse-6229.js | ||
test-process-external-stdio-close.js | ||
test-repl-function-redefinition-edge-case.js | ||
test-repl-require-context.js | ||
test-stdin-is-always-net.socket.js | ||
test-stdout-buffer-flush-on-exit.js | ||
test-url-parse-conformance.js | ||
test-vm-attributes-property-not-on-sandbox.js | ||
test-vm-data-property-writable.js | ||
test-vm-getters.js | ||
test-vm-global-non-writable-properties.js | ||
test-vm-inherited_properties.js | ||
testcfg.py |