mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
76340e3f10
* Remove needless RegExp flag In fixed case, `/g` flag is needless in the boolean context. * Remove needless RegExp capturing Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward. * Use test, not match/exec in boolean context match() and exec() return a complicated object, unneeded in a boolean context. * Do not needlessly repeat RegExp creation This commit takes RegExp creation out of cycles and other repetitions. As long as the RegExp does not use /g flag and match indices, we are safe here. In tests, this fix hardly gives a significant performance gain, but it increases clarity and maintainability, reassuring some RegExps to be identical. RegExp in functions are not taken out of their functions: while these functions are called many times and their RegExps are recreated with each call, the performance gain in test cases does not seem to be worth decreasing function self-dependency. PR-URL: https://github.com/nodejs/node/pull/13770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
123 lines
3.8 KiB
JavaScript
123 lines
3.8 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const net = require('net');
|
|
|
|
let tests_run = 0;
|
|
|
|
function pingPongTest(port, host, on_complete) {
|
|
const N = 1000;
|
|
let count = 0;
|
|
let sent_final_ping = false;
|
|
|
|
const server = net.createServer({ allowHalfOpen: true }, function(socket) {
|
|
assert.strictEqual(true, socket.remoteAddress !== null);
|
|
assert.strictEqual(true, socket.remoteAddress !== undefined);
|
|
const address = socket.remoteAddress;
|
|
if (host === '127.0.0.1') {
|
|
assert.strictEqual(address, '127.0.0.1');
|
|
} else if (host == null || host === 'localhost') {
|
|
assert(address === '127.0.0.1' || address === '::ffff:127.0.0.1');
|
|
} else {
|
|
console.log(`host = ${host}, remoteAddress = ${address}`);
|
|
assert.strictEqual(address, '::1');
|
|
}
|
|
|
|
socket.setEncoding('utf8');
|
|
socket.setNoDelay();
|
|
socket.timeout = 0;
|
|
|
|
socket.on('data', function(data) {
|
|
console.log(`server got: ${JSON.stringify(data)}`);
|
|
assert.strictEqual('open', socket.readyState);
|
|
assert.strictEqual(true, count <= N);
|
|
if (/PING/.test(data)) {
|
|
socket.write('PONG');
|
|
}
|
|
});
|
|
|
|
socket.on('end', function() {
|
|
assert.strictEqual('writeOnly', socket.readyState);
|
|
socket.end();
|
|
});
|
|
|
|
socket.on('close', function(had_error) {
|
|
assert.strictEqual(false, had_error);
|
|
assert.strictEqual('closed', socket.readyState);
|
|
socket.server.close();
|
|
});
|
|
});
|
|
|
|
server.listen(port, host, function() {
|
|
const client = net.createConnection(port, host);
|
|
|
|
client.setEncoding('utf8');
|
|
|
|
client.on('connect', function() {
|
|
assert.strictEqual('open', client.readyState);
|
|
client.write('PING');
|
|
});
|
|
|
|
client.on('data', function(data) {
|
|
console.log(`client got: ${data}`);
|
|
|
|
assert.strictEqual('PONG', data);
|
|
count += 1;
|
|
|
|
if (sent_final_ping) {
|
|
assert.strictEqual('readOnly', client.readyState);
|
|
return;
|
|
} else {
|
|
assert.strictEqual('open', client.readyState);
|
|
}
|
|
|
|
if (count < N) {
|
|
client.write('PING');
|
|
} else {
|
|
sent_final_ping = true;
|
|
client.write('PING');
|
|
client.end();
|
|
}
|
|
});
|
|
|
|
client.on('close', function() {
|
|
assert.strictEqual(N + 1, count);
|
|
assert.strictEqual(true, sent_final_ping);
|
|
if (on_complete) on_complete();
|
|
tests_run += 1;
|
|
});
|
|
});
|
|
}
|
|
|
|
/* All are run at once, so run on different ports */
|
|
pingPongTest(common.PORT, 'localhost');
|
|
pingPongTest(common.PORT + 1, null);
|
|
|
|
// This IPv6 isn't working on Solaris
|
|
if (!common.isSunOS) pingPongTest(common.PORT + 2, '::1');
|
|
|
|
process.on('exit', function() {
|
|
assert.strictEqual(common.isSunOS ? 2 : 3, tests_run);
|
|
});
|