mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
5f617c5f9e
`test-fs-watch-recursive` and `test-fs-watch` were both watching the same folder: `tmp/testsubdir` so running them sequentially on `OS X` could make `test-fs-watch` to fail due to events generated in the other test. Make them watch a random directory to fix the issue. Fixes: https://github.com/nodejs/node/issues/8045 PR-URL: https://github.com/nodejs/node/pull/8115 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
125 lines
2.9 KiB
JavaScript
125 lines
2.9 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var path = require('path');
|
|
var fs = require('fs');
|
|
|
|
var expectFilePath = common.isWindows ||
|
|
common.isLinux ||
|
|
common.isOSX;
|
|
|
|
var watchSeenOne = 0;
|
|
var watchSeenTwo = 0;
|
|
var watchSeenThree = 0;
|
|
|
|
var testDir = common.tmpDir;
|
|
|
|
var filenameOne = 'watch.txt';
|
|
var filepathOne = path.join(testDir, filenameOne);
|
|
|
|
var filenameTwo = 'hasOwnProperty';
|
|
var filepathTwo = filenameTwo;
|
|
var filepathTwoAbs = path.join(testDir, filenameTwo);
|
|
|
|
process.on('exit', function() {
|
|
assert.ok(watchSeenOne > 0);
|
|
assert.ok(watchSeenTwo > 0);
|
|
assert.ok(watchSeenThree > 0);
|
|
});
|
|
|
|
common.refreshTmpDir();
|
|
|
|
fs.writeFileSync(filepathOne, 'hello');
|
|
|
|
assert.doesNotThrow(
|
|
function() {
|
|
var watcher = fs.watch(filepathOne);
|
|
watcher.on('change', function(event, filename) {
|
|
assert.equal('change', event);
|
|
|
|
if (expectFilePath) {
|
|
assert.equal('watch.txt', filename);
|
|
}
|
|
watcher.close();
|
|
++watchSeenOne;
|
|
});
|
|
}
|
|
);
|
|
|
|
setImmediate(function() {
|
|
fs.writeFileSync(filepathOne, 'world');
|
|
});
|
|
|
|
|
|
process.chdir(testDir);
|
|
|
|
fs.writeFileSync(filepathTwoAbs, 'howdy');
|
|
|
|
assert.doesNotThrow(
|
|
function() {
|
|
var watcher = fs.watch(filepathTwo, function(event, filename) {
|
|
assert.equal('change', event);
|
|
|
|
if (expectFilePath) {
|
|
assert.equal('hasOwnProperty', filename);
|
|
}
|
|
watcher.close();
|
|
++watchSeenTwo;
|
|
});
|
|
}
|
|
);
|
|
|
|
setImmediate(function() {
|
|
fs.writeFileSync(filepathTwoAbs, 'pardner');
|
|
});
|
|
|
|
const filenameThree = 'newfile.txt';
|
|
const testsubdir = fs.mkdtempSync(testDir + path.sep);
|
|
const filepathThree = path.join(testsubdir, filenameThree);
|
|
|
|
assert.doesNotThrow(
|
|
function() {
|
|
var watcher = fs.watch(testsubdir, function(event, filename) {
|
|
var renameEv = common.isSunOS ? 'change' : 'rename';
|
|
assert.equal(renameEv, event);
|
|
if (expectFilePath) {
|
|
assert.equal('newfile.txt', filename);
|
|
} else {
|
|
assert.equal(null, filename);
|
|
}
|
|
watcher.close();
|
|
++watchSeenThree;
|
|
});
|
|
}
|
|
);
|
|
|
|
setImmediate(function() {
|
|
var fd = fs.openSync(filepathThree, 'w');
|
|
fs.closeSync(fd);
|
|
});
|
|
|
|
// https://github.com/joyent/node/issues/2293 - non-persistent watcher should
|
|
// not block the event loop
|
|
fs.watch(__filename, {persistent: false}, function() {
|
|
assert(0);
|
|
});
|
|
|
|
// whitebox test to ensure that wrapped FSEvent is safe
|
|
// https://github.com/joyent/node/issues/6690
|
|
var oldhandle;
|
|
assert.throws(function() {
|
|
var w = fs.watch(__filename, function(event, filename) { });
|
|
oldhandle = w._handle;
|
|
w._handle = { close: w._handle.close };
|
|
w.close();
|
|
}, TypeError);
|
|
oldhandle.close(); // clean up
|
|
|
|
assert.throws(function() {
|
|
var w = fs.watchFile(__filename, {persistent: false}, function() {});
|
|
oldhandle = w._handle;
|
|
w._handle = { stop: w._handle.stop };
|
|
w.stop();
|
|
}, TypeError);
|
|
oldhandle.stop(); // clean up
|