mirror of
https://github.com/nodejs/node.git
synced 2024-11-30 07:27:22 +01:00
5a17ab3ff3
The 'Main' function in tools/test.py file was using a variable named ``all_outcomes`` to store a value not being used. It is a best practice to name unused variables, often return values of functions/methods (as in this case) as ``_`` [1]. This just helps keep the code a bit cleaner and avoid any silly mistakes. PR-URL: https://github.com/nodejs/node/pull/16171 Refs: [1] https://stackoverflow.com/a/5477153 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> |
||
|---|---|---|
| .. | ||
| configure.d | ||
| doc | ||
| eslint | ||
| eslint-rules | ||
| gyp | ||
| icu | ||
| macos-installer | ||
| msvs | ||
| pkgsrc | ||
| rpm | ||
| certdata.txt | ||
| check-imports.py | ||
| compress_json.py | ||
| cpplint.py | ||
| create_android_makefiles | ||
| create_expfile.sh | ||
| genv8constants.py | ||
| getmoduleversion.py | ||
| getnodeversion.py | ||
| gyp_node.py | ||
| install.py | ||
| js2c.py | ||
| license2rtf.js | ||
| license-builder.sh | ||
| lint-js.js | ||
| lsan_suppressions.txt | ||
| macosx-firewall.sh | ||
| make-v8.sh | ||
| Makefile | ||
| mk-ca-bundle.pl | ||
| mkssldef.py | ||
| osx-codesign.sh | ||
| osx-pkg-postinstall.sh | ||
| osx-productsign.sh | ||
| release.sh | ||
| run-valgrind.py | ||
| sign.bat | ||
| specialize_node_d.py | ||
| test-npm-package.js | ||
| test-npm.sh | ||
| test-v8.bat | ||
| test.py | ||
| update-authors.sh | ||
| update-eslint.sh | ||
| utils.py | ||