0
0
mirror of https://github.com/nodejs/node.git synced 2024-11-30 07:27:22 +01:00
nodejs/.github
Richard Lau 9bfa4a9376
build: do not use setup-node in build workflows
The setup-node GitHub Action installs problem matchers that happen
to match the warning message format of Visual Studio's C/C++ compiler.
This is resulting in all of our pull requests being annotated with
`Unchanged files with check annotations` which are confusing to new
contributors as they are not due to the changes in the pull request.

The action is used to run `npx envinfo` to dump some information into
the logs before the actual build. All GitHub hosted runners already
have a version of Node.js installed (12.x at the time of this commit)
which we can use to run `envinfo`. Remove the action to avoid using
the problematic problem matcher.

PR-URL: https://github.com/nodejs/node/pull/31349
Fixes: https://github.com/nodejs/node/issues/31347
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-01-16 01:39:24 -05:00
..
ISSUE_TEMPLATE meta: clarify scope of new nodejs.org issue choice 2019-12-30 21:20:38 -08:00
workflows build: do not use setup-node in build workflows 2020-01-16 01:39:24 -05:00
ISSUE_TEMPLATE.md
PULL_REQUEST_TEMPLATE.md doc: add dco to github pr template 2019-08-26 09:52:50 -07:00
SUPPORT.md