0
0
mirror of https://github.com/nodejs/node.git synced 2024-11-30 23:43:09 +01:00
nodejs/test/addons-napi
Nicholas Drane 094d92bb57 test: remove ambiguous error messages from test_error
assert.strictEqual accepts 3 arguments, the last of which allows for
user-specified error message to be thrown when the assertion fails.
Unfortunately, this error message is less helpful than the default when
it is vague. This commit removes vague, user-specified error messages,
instead relying on clearer, default error messages.

PR-URL: https://github.com/nodejs/node/pull/17812
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2017-12-25 14:02:46 -08:00
..
1_hello_world n-api: refactor napi_addon_register_func 2017-09-14 15:02:10 -04:00
2_function_arguments n-api: refactor napi_addon_register_func 2017-09-14 15:02:10 -04:00
3_callbacks n-api: refactor napi_addon_register_func 2017-09-14 15:02:10 -04:00
4_object_factory n-api: add optional string length parameters 2017-09-18 17:47:34 -04:00
5_function_factory n-api: add optional string length parameters 2017-09-18 17:47:34 -04:00
6_object_wrap n-api: add optional string length parameters 2017-09-18 17:47:34 -04:00
7_factory_wrap tools: add cpplint rule for NULL usage 2017-12-01 07:45:05 +01:00
8_passing_wrapped n-api: add optional string length parameters 2017-09-18 17:47:34 -04:00
test_array n-api: refactor napi_addon_register_func 2017-09-14 15:02:10 -04:00
test_async n-api: fix warning about size_t compare with int 2017-09-24 10:47:27 -04:00
test_buffer test: remove literals that obscure assert messages 2017-12-14 11:00:52 -08:00
test_constructor n-api,test: use module name macro 2017-10-13 15:08:38 +03:00
test_conversions n-api: fix warning about size_t compare with int 2017-09-24 10:47:27 -04:00
test_dataview test: include actual value in assertion message 2017-10-29 09:34:26 +01:00
test_env_sharing n-api: fix warning about size_t compare with int 2017-09-24 10:47:27 -04:00
test_error test: remove ambiguous error messages from test_error 2017-12-25 14:02:46 -08:00
test_exception test: improve assert messages in napi exception test 2017-11-08 00:32:19 +00:00
test_fatal n-api: fix warning about size_t compare with int 2017-09-24 10:47:27 -04:00
test_function n-api: fix warning about size_t compare with int 2017-09-24 10:47:27 -04:00
test_general n-api: add helper for addons to get the event loop 2017-11-21 08:33:23 +01:00
test_handle_scope doc: use American spellings per style guide 2017-12-06 16:52:31 -08:00
test_make_callback tools: add cpplint rule for NULL usage 2017-12-01 07:45:05 +01:00
test_make_callback_recurse tools: add cpplint rule for NULL usage 2017-12-01 07:45:05 +01:00
test_number doc: use American spellings per style guide 2017-12-06 16:52:31 -08:00
test_object n-api: refactor napi_addon_register_func 2017-09-14 15:02:10 -04:00
test_promise test: add unhandled rejection guard 2017-12-12 17:14:21 -02:00
test_properties n-api: fix warning about size_t compare with int 2017-09-24 10:47:27 -04:00
test_reference n-api: refactor napi_addon_register_func 2017-09-14 15:02:10 -04:00
test_string n-api: add check for large strings 2017-09-29 17:44:41 -04:00
test_symbol n-api: refactor napi_addon_register_func 2017-09-14 15:02:10 -04:00
test_typedarray assert: use Object.is comparison in .strictEqual 2017-11-22 09:16:49 -08:00
test_uv_loop n-api: add helper for addons to get the event loop 2017-11-21 08:33:23 +01:00
test_warning n-api: use module name macro 2017-10-15 16:00:29 -07:00
.gitignore
common.h n-api: add code parameter to error helpers 2017-07-13 15:05:19 -04:00
testcfg.py n-api: remove n-api module loading flag 2017-09-19 19:06:44 -04:00