mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
9180140231
Queued write requests should be invoked on handle close, otherwise the "consumer" might be already destroyed when the write callbacks of the "consumed" handle will be invoked. Same applies to the shutdown requests. Make sure to "move" away socket from server to not break the `connections` counter in `net.js`. Otherwise it might not call `close` callback, or call it too early. Fix: https://github.com/iojs/io.js/issues/1696 PR-URL: https://github.com/nodejs/io.js/pull/1910 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
40 lines
746 B
JavaScript
40 lines
746 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const StreamWrap = require('_stream_wrap');
|
|
const Duplex = require('stream').Duplex;
|
|
const ShutdownWrap = process.binding('stream_wrap').ShutdownWrap;
|
|
|
|
var done = false;
|
|
|
|
function testShutdown(callback) {
|
|
var stream = new Duplex({
|
|
read: function() {
|
|
},
|
|
write: function() {
|
|
}
|
|
});
|
|
|
|
var wrap = new StreamWrap(stream);
|
|
|
|
var req = new ShutdownWrap();
|
|
req.oncomplete = function(code) {
|
|
assert(code < 0);
|
|
callback();
|
|
};
|
|
req.handle = wrap._handle;
|
|
|
|
// Close the handle to simulate
|
|
wrap.destroy();
|
|
req.handle.shutdown(req);
|
|
}
|
|
|
|
testShutdown(function() {
|
|
done = true;
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
assert(done);
|
|
});
|