mirror of
https://github.com/nodejs/node.git
synced 2024-11-30 07:27:22 +01:00
04b4d15b39
Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
58 lines
1.7 KiB
JavaScript
58 lines
1.7 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
var assert = require('assert');
|
|
var net = require('net');
|
|
var http = require('http');
|
|
|
|
// wget sends an HTTP/1.0 request with Connection: Keep-Alive
|
|
//
|
|
// Sending back a chunked response to an HTTP/1.0 client would be wrong,
|
|
// so what has to happen in this case is that the connection is closed
|
|
// by the server after the entity body if the Content-Length was not
|
|
// sent.
|
|
//
|
|
// If the Content-Length was sent, we can probably safely honor the
|
|
// keep-alive request, even though HTTP 1.0 doesn't say that the
|
|
// connection can be kept open. Presumably any client sending this
|
|
// header knows that it is extending HTTP/1.0 and can handle the
|
|
// response. We don't test that here however, just that if the
|
|
// content-length is not provided, that the connection is in fact
|
|
// closed.
|
|
|
|
var server = http.createServer(function(req, res) {
|
|
res.writeHead(200, {'Content-Type': 'text/plain'});
|
|
res.write('hello ');
|
|
res.write('world\n');
|
|
res.end();
|
|
});
|
|
server.listen(0);
|
|
|
|
server.on('listening', common.mustCall(function() {
|
|
var c = net.createConnection(this.address().port);
|
|
var server_response = '';
|
|
|
|
c.setEncoding('utf8');
|
|
|
|
c.on('connect', function() {
|
|
c.write('GET / HTTP/1.0\r\n' +
|
|
'Connection: Keep-Alive\r\n\r\n');
|
|
});
|
|
|
|
c.on('data', function(chunk) {
|
|
console.log(chunk);
|
|
server_response += chunk;
|
|
});
|
|
|
|
c.on('end', common.mustCall(function() {
|
|
const m = server_response.split('\r\n\r\n');
|
|
assert.strictEqual(m[1], 'hello world\n');
|
|
console.log('got end');
|
|
c.end();
|
|
}));
|
|
|
|
c.on('close', common.mustCall(function() {
|
|
console.log('got close');
|
|
server.close();
|
|
}));
|
|
}));
|