mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
04b4d15b39
Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
21 lines
620 B
JavaScript
21 lines
620 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
var http = require('http');
|
|
var url = require('url');
|
|
|
|
var server = http.createServer(common.mustCall(function(req, res) {
|
|
res.end();
|
|
})).listen(0, '127.0.0.1', common.mustCall(function() {
|
|
var opts = url.parse(`http://127.0.0.1:${this.address().port}/`);
|
|
|
|
// remove the `protocol` field… the `http` module should fall back
|
|
// to "http:", as defined by the global, default `http.Agent` instance.
|
|
opts.agent = new http.Agent();
|
|
opts.agent.protocol = null;
|
|
|
|
http.get(opts, common.mustCall(function(res) {
|
|
res.resume();
|
|
server.close();
|
|
}));
|
|
}));
|