mirror of
https://github.com/nodejs/node.git
synced 2024-11-30 07:27:22 +01:00
c5a18e748d
This reverts commit c86c1eeab5
.
original commit message:
This patch
1. moves the basic validation of arguments to `truncate` family
of functions to the JavaScript layer from the C++ layer.
2. makes sure that the File Descriptors are validated strictly.
PR-URL: #2498
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/7950
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
145 lines
3.7 KiB
JavaScript
145 lines
3.7 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var util = require('util');
|
|
var fs = require('fs');
|
|
|
|
var tests_ok = 0;
|
|
var tests_run = 0;
|
|
|
|
function stat_resource(resource) {
|
|
if (typeof resource == 'string') {
|
|
return fs.statSync(resource);
|
|
} else {
|
|
// ensure mtime has been written to disk
|
|
fs.fsyncSync(resource);
|
|
return fs.fstatSync(resource);
|
|
}
|
|
}
|
|
|
|
function check_mtime(resource, mtime) {
|
|
mtime = fs._toUnixTimestamp(mtime);
|
|
var stats = stat_resource(resource);
|
|
var real_mtime = fs._toUnixTimestamp(stats.mtime);
|
|
// check up to single-second precision
|
|
// sub-second precision is OS and fs dependant
|
|
return mtime - real_mtime < 2;
|
|
}
|
|
|
|
function expect_errno(syscall, resource, err, errno) {
|
|
if (err && (err.code === errno || err.code === 'ENOSYS')) {
|
|
tests_ok++;
|
|
} else {
|
|
console.log('FAILED:', 'expect_errno', util.inspect(arguments));
|
|
}
|
|
}
|
|
|
|
function expect_ok(syscall, resource, err, atime, mtime) {
|
|
if (!err && check_mtime(resource, mtime) ||
|
|
err && err.code === 'ENOSYS') {
|
|
tests_ok++;
|
|
} else {
|
|
console.log('FAILED:', 'expect_ok', util.inspect(arguments));
|
|
}
|
|
}
|
|
|
|
// the tests assume that __filename belongs to the user running the tests
|
|
// this should be a fairly safe assumption; testing against a temp file
|
|
// would be even better though (node doesn't have such functionality yet)
|
|
function runTest(atime, mtime, callback) {
|
|
|
|
var fd;
|
|
//
|
|
// test synchronized code paths, these functions throw on failure
|
|
//
|
|
function syncTests() {
|
|
fs.utimesSync(__filename, atime, mtime);
|
|
expect_ok('utimesSync', __filename, undefined, atime, mtime);
|
|
tests_run++;
|
|
|
|
// some systems don't have futimes
|
|
// if there's an error, it should be ENOSYS
|
|
try {
|
|
tests_run++;
|
|
fs.futimesSync(fd, atime, mtime);
|
|
expect_ok('futimesSync', fd, undefined, atime, mtime);
|
|
} catch (ex) {
|
|
expect_errno('futimesSync', fd, ex, 'ENOSYS');
|
|
}
|
|
|
|
var err;
|
|
err = undefined;
|
|
try {
|
|
fs.utimesSync('foobarbaz', atime, mtime);
|
|
} catch (ex) {
|
|
err = ex;
|
|
}
|
|
expect_errno('utimesSync', 'foobarbaz', err, 'ENOENT');
|
|
tests_run++;
|
|
|
|
err = undefined;
|
|
try {
|
|
fs.futimesSync(-1, atime, mtime);
|
|
} catch (ex) {
|
|
err = ex;
|
|
}
|
|
expect_errno('futimesSync', -1, err, 'EBADF');
|
|
tests_run++;
|
|
}
|
|
|
|
//
|
|
// test async code paths
|
|
//
|
|
fs.utimes(__filename, atime, mtime, function(err) {
|
|
expect_ok('utimes', __filename, err, atime, mtime);
|
|
|
|
fs.utimes('foobarbaz', atime, mtime, function(err) {
|
|
expect_errno('utimes', 'foobarbaz', err, 'ENOENT');
|
|
|
|
// don't close this fd
|
|
if (common.isWindows) {
|
|
fd = fs.openSync(__filename, 'r+');
|
|
} else {
|
|
fd = fs.openSync(__filename, 'r');
|
|
}
|
|
|
|
fs.futimes(fd, atime, mtime, function(err) {
|
|
expect_ok('futimes', fd, err, atime, mtime);
|
|
|
|
fs.futimes(-1, atime, mtime, function(err) {
|
|
expect_errno('futimes', -1, err, 'EBADF');
|
|
syncTests();
|
|
callback();
|
|
});
|
|
tests_run++;
|
|
});
|
|
tests_run++;
|
|
});
|
|
tests_run++;
|
|
});
|
|
tests_run++;
|
|
}
|
|
|
|
var stats = fs.statSync(__filename);
|
|
|
|
// run tests
|
|
runTest(new Date('1982-09-10 13:37'), new Date('1982-09-10 13:37'), function() {
|
|
runTest(new Date(), new Date(), function() {
|
|
runTest(123456.789, 123456.789, function() {
|
|
runTest(stats.mtime, stats.mtime, function() {
|
|
runTest(NaN, Infinity, function() {
|
|
runTest('123456', -1, function() {
|
|
// done
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
|
|
process.on('exit', function() {
|
|
console.log('Tests run / ok:', tests_run, '/', tests_ok);
|
|
assert.equal(tests_ok, tests_run);
|
|
});
|