mirror of
https://github.com/nodejs/node.git
synced 2024-11-30 07:27:22 +01:00
21b0a27af8
This reverts commit 9359de9dd2.
Original Commit Message:
The "fs" module has two functions called `maybeCallback` and
`makeCallback`, as of now.
The `maybeCallback` creates a default function to report errors, if the
parameter passed is not a function object. Basically, if the callback
is omitted in some cases, this function is used to create a default
callback function.
The `makeCallback`, OTOH, creates a default function only if the
parameter passed is `undefined`, and if it is not a function object it
will throw an `Error`.
This patch removes the `maybeCallback` function and makes the callback
function argument mandatory for all the async functions.
PR-URL: https://github.com/nodejs/node/pull/7168
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/7846
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
37 lines
792 B
JavaScript
37 lines
792 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
|
|
common.refreshTmpDir();
|
|
|
|
// test creating and reading hard link
|
|
const srcPath = path.join(common.tmpDir, 'hardlink-target.txt');
|
|
const dstPath = path.join(common.tmpDir, 'link1.js');
|
|
fs.writeFileSync(srcPath, 'hello world');
|
|
|
|
const callback = function(err) {
|
|
if (err) throw err;
|
|
const dstContent = fs.readFileSync(dstPath, 'utf8');
|
|
assert.strictEqual('hello world', dstContent);
|
|
};
|
|
|
|
fs.link(srcPath, dstPath, common.mustCall(callback));
|
|
|
|
// test error outputs
|
|
|
|
assert.throws(
|
|
function() {
|
|
fs.link();
|
|
},
|
|
/src must be a string or Buffer/
|
|
);
|
|
|
|
assert.throws(
|
|
function() {
|
|
fs.link('abc');
|
|
},
|
|
/dest must be a string or Buffer/
|
|
);
|