mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
7b8058a39e
This patch refactors the branches for choosing the mode to run Node.js in `internal/bootstrap/node.js`. Instead of inlining the decision making all in `startup`, we create a `startExecution()` function which either detects and start the non-user-code mode, or prepares for user code execution (worker setup, preloading modules) and starts user code execution. We use early returns when we decide the mode to run Node.js in for fewer indentations and better readability. This patch also adds a few comments about the command-line switches and a few TODOs to remove underscore properties on `process` that are mainly used for bootstrap mode branching. It also includes a few other refactoring such as inlining functions/variables that are not reused and removing the default argument of `evalScript` for better clarity. PR-URL: https://github.com/nodejs/node/pull/24673 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> |
||
|---|---|---|
| .. | ||
| abort | ||
| addons | ||
| addons-napi | ||
| async-hooks | ||
| benchmark | ||
| cctest | ||
| code-cache | ||
| common | ||
| doctool | ||
| es-module | ||
| fixtures | ||
| internet | ||
| known_issues | ||
| message | ||
| parallel | ||
| pseudo-tty | ||
| pummel | ||
| sequential | ||
| testpy | ||
| tick-processor | ||
| v8-updates | ||
| wpt | ||
| .eslintrc.yaml | ||
| README.md | ||
| root.status | ||
Node.js Core Tests
This directory contains code and data used to test the Node.js implementation.
For a detailed guide on how to write tests in this directory, see the guide on writing tests.
On how to run tests in this directory, see the contributing guide.
For the tests to successfully run on Windows, Node.js has to be checked out from
GitHub with the autocrlf git config flag set to true.
Test Directories
| Directory | Runs on CI | Purpose |
|---|---|---|
abort |
Yes | Tests for when the --abort-on-uncaught-exception flag is used. |
addons |
Yes | Tests for addon functionality along with some tests that require an addon to function properly. |
addons-napi |
Yes | Tests for n-api functionality. |
async-hooks |
Yes | Tests for async_hooks functionality. |
benchmark |
No | Test minimal functionality of benchmarks. |
cctest |
Yes | C++ tests that are run as part of the build process. |
code-cache |
No | Tests for a Node.js binary compiled with V8 code cache. |
common |
Common modules shared among many tests. Documentation | |
doctool |
Yes | Tests for the documentation generator. |
es-module |
Yes | Test ESM module loading. |
fixtures |
Test fixtures used in various tests throughout the test suite. | |
internet |
No | Tests that make real outbound connections (mainly networking related modules). Tests for networking related modules may also be present in other directories, but those tests do not make outbound connections. |
known_issues |
Yes | Tests reproducing known issues within the system. All tests inside of this directory are expected to fail consistently. If a test doesn't fail on certain platforms, those should be skipped via known_issues.status. |
message |
Yes | Tests for messages that are output for various conditions (console.log, error messages etc.) |
parallel |
Yes | Various tests that are able to be run in parallel. |
pseudo-tty |
Yes | Tests that require stdin/stdout/stderr to be a TTY. |
pummel |
No | Various tests for various modules / system functionality operating under load. |
sequential |
Yes | Various tests that are run sequentially. |
testpy |
Test configuration utility used by various test suites. | |
tick-processor |
No | Tests for the V8 tick processor integration. The tests are for the logic in lib/internal/v8_prof_processor.js and lib/internal/v8_prof_polyfill.js. The tests confirm that the profile processor packages the correct set of scripts from V8 and introduces the correct platform specific logic. |
v8-updates |
No | Tests for V8 performance integration. |