mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
76340e3f10
* Remove needless RegExp flag In fixed case, `/g` flag is needless in the boolean context. * Remove needless RegExp capturing Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward. * Use test, not match/exec in boolean context match() and exec() return a complicated object, unneeded in a boolean context. * Do not needlessly repeat RegExp creation This commit takes RegExp creation out of cycles and other repetitions. As long as the RegExp does not use /g flag and match indices, we are safe here. In tests, this fix hardly gives a significant performance gain, but it increases clarity and maintainability, reassuring some RegExps to be identical. RegExp in functions are not taken out of their functions: while these functions are called many times and their RegExps are recreated with each call, the performance gain in test cases does not seem to be worth decreasing function self-dependency. PR-URL: https://github.com/nodejs/node/pull/13770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
18 lines
479 B
JavaScript
18 lines
479 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const net = require('net');
|
|
|
|
// This tests checks that if server._handle.getsockname
|
|
// returns an error number, an error is thrown.
|
|
|
|
const server = net.createServer({});
|
|
server.listen(0, common.mustCall(function() {
|
|
server._handle.getsockname = function(out) {
|
|
return -1;
|
|
};
|
|
assert.throws(() => this.address(),
|
|
/^Error: address [\w|\s-\d]+$/);
|
|
server.close();
|
|
}));
|