mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
c6b6c92185
This makes a effort to make sure all of these errors will actually also show the received input. On top of that it refactors a few tests for better maintainability. It will also change the returned type to always be a simple typeof instead of special handling null. PR-URL: https://github.com/nodejs/node/pull/19445 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
72 lines
1.8 KiB
JavaScript
72 lines
1.8 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const http2 = require('http2');
|
|
|
|
const server = http2.createServer();
|
|
|
|
const types = [
|
|
true,
|
|
{},
|
|
[],
|
|
null,
|
|
new Date()
|
|
];
|
|
|
|
server.on('stream', common.mustCall((stream) => {
|
|
const session = stream.session;
|
|
|
|
types.forEach((input) => {
|
|
common.expectsError(
|
|
() => session.goaway(input),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "code" argument must be of type number. Received type ' +
|
|
typeof input
|
|
}
|
|
);
|
|
common.expectsError(
|
|
() => session.goaway(0, input),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "lastStreamID" argument must be of type number. ' +
|
|
`Received type ${typeof input}`
|
|
}
|
|
);
|
|
common.expectsError(
|
|
() => session.goaway(0, 0, input),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "opaqueData" argument must be one of type Buffer, ' +
|
|
`TypedArray, or DataView. Received type ${typeof input}`
|
|
}
|
|
);
|
|
});
|
|
|
|
stream.session.destroy();
|
|
}));
|
|
|
|
server.listen(
|
|
0,
|
|
common.mustCall(() => {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
// On certain operating systems, an ECONNRESET may occur. We do not need
|
|
// to test for it here. Do not make this a mustCall
|
|
client.on('error', () => {});
|
|
const req = client.request();
|
|
// On certain operating systems, an ECONNRESET may occur. We do not need
|
|
// to test for it here. Do not make this a mustCall
|
|
req.on('error', () => {});
|
|
req.resume();
|
|
req.on('close', common.mustCall(() => {
|
|
client.close();
|
|
server.close();
|
|
}));
|
|
})
|
|
);
|