mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
237aa7e9ae
Rather than an option, introduce a method and an event...
```js
server.on('stream', (stream) => {
stream.respond(undefined, { waitForTrailers: true });
stream.on('wantTrailers', () => {
stream.sendTrailers({ abc: 'xyz'});
});
stream.end('hello world');
});
```
This is a breaking change in the API such that the prior
`options.getTrailers` is no longer supported at all.
Ordinarily this would be semver-major and require a
deprecation but the http2 stuff is still experimental.
PR-URL: https://github.com/nodejs/node/pull/19959
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
59 lines
1.4 KiB
JavaScript
59 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const http2 = require('http2');
|
|
|
|
// Check if correct errors are emitted when wrong type of data is passed
|
|
// to certain options of ClientHttp2Session request method
|
|
|
|
const optionsToTest = {
|
|
endStream: 'boolean',
|
|
weight: 'number',
|
|
parent: 'number',
|
|
exclusive: 'boolean',
|
|
silent: 'boolean'
|
|
};
|
|
|
|
const types = {
|
|
boolean: true,
|
|
function: () => {},
|
|
number: 1,
|
|
object: {},
|
|
array: [],
|
|
null: null,
|
|
symbol: Symbol('test')
|
|
};
|
|
|
|
const server = http2.createServer(common.mustNotCall());
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const port = server.address().port;
|
|
const client = http2.connect(`http://localhost:${port}`);
|
|
|
|
client.on('connect', () => {
|
|
Object.keys(optionsToTest).forEach((option) => {
|
|
Object.keys(types).forEach((type) => {
|
|
if (type === optionsToTest[option])
|
|
return;
|
|
|
|
common.expectsError(
|
|
() => client.request({
|
|
':method': 'CONNECT',
|
|
':authority': `localhost:${port}`
|
|
}, {
|
|
[option]: types[type]
|
|
}), {
|
|
type: TypeError,
|
|
code: 'ERR_INVALID_OPT_VALUE',
|
|
message: `The value "${String(types[type])}" is invalid ` +
|
|
`for option "${option}"`
|
|
});
|
|
});
|
|
});
|
|
server.close();
|
|
client.close();
|
|
});
|
|
}));
|