mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
1fd69872e6
We've added a number of tests that hook into ESLint which can error when running the test suite with the distributed tarball. This PR adds a new test helper `common.skipIfEslintMissing` and will skip remaining tests in a file when `ESLint` is not available at `tools/node_modules/eslint` PR-URL: https://github.com/nodejs/node/pull/18807 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
55 lines
1.4 KiB
JavaScript
55 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
|
|
common.skipIfEslintMissing();
|
|
|
|
const RuleTester = require('../../tools/node_modules/eslint').RuleTester;
|
|
const rule = require('../../tools/eslint-rules/prefer-assert-methods');
|
|
|
|
new RuleTester().run('prefer-assert-methods', rule, {
|
|
valid: [
|
|
'assert.strictEqual(foo, bar);',
|
|
'assert(foo === bar && baz);',
|
|
'assert.notStrictEqual(foo, bar);',
|
|
'assert(foo !== bar && baz);',
|
|
'assert.equal(foo, bar);',
|
|
'assert(foo == bar && baz);',
|
|
'assert.notEqual(foo, bar);',
|
|
'assert(foo != bar && baz);',
|
|
'assert.ok(foo);',
|
|
'assert.ok(foo != bar);',
|
|
'assert.ok(foo === bar && baz);'
|
|
],
|
|
invalid: [
|
|
{
|
|
code: 'assert(foo == bar);',
|
|
errors: [{
|
|
message: "'assert.equal' should be used instead of '=='"
|
|
}],
|
|
output: 'assert.equal(foo, bar);'
|
|
},
|
|
{
|
|
code: 'assert(foo === bar);',
|
|
errors: [{
|
|
message: "'assert.strictEqual' should be used instead of '==='"
|
|
}],
|
|
output: 'assert.strictEqual(foo, bar);'
|
|
},
|
|
{
|
|
code: 'assert(foo != bar);',
|
|
errors: [{
|
|
message: "'assert.notEqual' should be used instead of '!='"
|
|
}],
|
|
output: 'assert.notEqual(foo, bar);'
|
|
},
|
|
{
|
|
code: 'assert(foo !== bar);',
|
|
errors: [{
|
|
message: "'assert.notStrictEqual' should be used instead of '!=='"
|
|
}],
|
|
output: 'assert.notStrictEqual(foo, bar);'
|
|
}
|
|
]
|
|
});
|