mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
2a9f1ad4b0
Have clearer ownership relations between the `Http2Ping`, `Http2Settings` and `Http2Session` objects. Ping and Settings objects are now owned by the `Http2Session` instance, and deleted along with it, so neither type of object refers to the session after it is gone. In the case of `Http2Ping`s, that deletion is slightly delayed, so we explicitly reset its `session_` property. Fixes: https://github.com/nodejs/node/issues/28088 PR-URL: https://github.com/nodejs/node/pull/28150 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
149 lines
4.7 KiB
C++
149 lines
4.7 KiB
C++
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
#ifndef SRC_BASE_OBJECT_INL_H_
|
|
#define SRC_BASE_OBJECT_INL_H_
|
|
|
|
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
|
|
|
|
#include "base_object.h"
|
|
#include "env-inl.h"
|
|
#include "util.h"
|
|
#include "v8.h"
|
|
|
|
namespace node {
|
|
|
|
BaseObject::BaseObject(Environment* env, v8::Local<v8::Object> object)
|
|
: persistent_handle_(env->isolate(), object),
|
|
env_(env) {
|
|
CHECK_EQ(false, object.IsEmpty());
|
|
CHECK_GT(object->InternalFieldCount(), 0);
|
|
object->SetAlignedPointerInInternalField(0, static_cast<void*>(this));
|
|
env_->AddCleanupHook(DeleteMe, static_cast<void*>(this));
|
|
}
|
|
|
|
BaseObject::~BaseObject() {
|
|
RemoveCleanupHook();
|
|
|
|
if (persistent_handle_.IsEmpty()) {
|
|
// This most likely happened because the weak callback below cleared it.
|
|
return;
|
|
}
|
|
|
|
{
|
|
v8::HandleScope handle_scope(env_->isolate());
|
|
object()->SetAlignedPointerInInternalField(0, nullptr);
|
|
}
|
|
}
|
|
|
|
void BaseObject::RemoveCleanupHook() {
|
|
env_->RemoveCleanupHook(DeleteMe, static_cast<void*>(this));
|
|
}
|
|
|
|
v8::Global<v8::Object>& BaseObject::persistent() {
|
|
return persistent_handle_;
|
|
}
|
|
|
|
|
|
v8::Local<v8::Object> BaseObject::object() const {
|
|
return PersistentToLocal::Default(env_->isolate(), persistent_handle_);
|
|
}
|
|
|
|
v8::Local<v8::Object> BaseObject::object(v8::Isolate* isolate) const {
|
|
v8::Local<v8::Object> handle = object();
|
|
|
|
DCHECK_EQ(handle->CreationContext()->GetIsolate(), isolate);
|
|
DCHECK_EQ(env_->isolate(), isolate);
|
|
|
|
return handle;
|
|
}
|
|
|
|
Environment* BaseObject::env() const {
|
|
return env_;
|
|
}
|
|
|
|
|
|
BaseObject* BaseObject::FromJSObject(v8::Local<v8::Object> obj) {
|
|
CHECK_GT(obj->InternalFieldCount(), 0);
|
|
return static_cast<BaseObject*>(obj->GetAlignedPointerFromInternalField(0));
|
|
}
|
|
|
|
|
|
template <typename T>
|
|
T* BaseObject::FromJSObject(v8::Local<v8::Object> object) {
|
|
return static_cast<T*>(FromJSObject(object));
|
|
}
|
|
|
|
|
|
void BaseObject::MakeWeak() {
|
|
persistent_handle_.SetWeak(
|
|
this,
|
|
[](const v8::WeakCallbackInfo<BaseObject>& data) {
|
|
std::unique_ptr<BaseObject> obj(data.GetParameter());
|
|
// Clear the persistent handle so that ~BaseObject() doesn't attempt
|
|
// to mess with internal fields, since the JS object may have
|
|
// transitioned into an invalid state.
|
|
// Refs: https://github.com/nodejs/node/issues/18897
|
|
obj->persistent_handle_.Reset();
|
|
}, v8::WeakCallbackType::kParameter);
|
|
}
|
|
|
|
|
|
void BaseObject::ClearWeak() {
|
|
persistent_handle_.ClearWeak();
|
|
}
|
|
|
|
|
|
v8::Local<v8::FunctionTemplate>
|
|
BaseObject::MakeLazilyInitializedJSTemplate(Environment* env) {
|
|
auto constructor = [](const v8::FunctionCallbackInfo<v8::Value>& args) {
|
|
DCHECK(args.IsConstructCall());
|
|
DCHECK_GT(args.This()->InternalFieldCount(), 0);
|
|
args.This()->SetAlignedPointerInInternalField(0, nullptr);
|
|
};
|
|
|
|
v8::Local<v8::FunctionTemplate> t = env->NewFunctionTemplate(constructor);
|
|
t->InstanceTemplate()->SetInternalFieldCount(1);
|
|
return t;
|
|
}
|
|
|
|
template <int Field>
|
|
void BaseObject::InternalFieldGet(
|
|
v8::Local<v8::String> property,
|
|
const v8::PropertyCallbackInfo<v8::Value>& info) {
|
|
info.GetReturnValue().Set(info.This()->GetInternalField(Field));
|
|
}
|
|
|
|
template <int Field, bool (v8::Value::* typecheck)() const>
|
|
void BaseObject::InternalFieldSet(v8::Local<v8::String> property,
|
|
v8::Local<v8::Value> value,
|
|
const v8::PropertyCallbackInfo<void>& info) {
|
|
// This could be e.g. value->IsFunction().
|
|
CHECK(((*value)->*typecheck)());
|
|
info.This()->SetInternalField(Field, value);
|
|
}
|
|
|
|
} // namespace node
|
|
|
|
#endif // defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
|
|
|
|
#endif // SRC_BASE_OBJECT_INL_H_
|