mirror of
https://github.com/nodejs/node.git
synced 2024-11-30 15:30:56 +01:00
01d049165c
Don't disconnect the child until all exceptions are thrown. Fixes: https://github.com/nodejs/node/issues/18659 PR-URL: https://github.com/nodejs/node/pull/18692 Fixes: https://github.com/nodejs/node/issues/18659 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
60 lines
1.7 KiB
JavaScript
60 lines
1.7 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
const spawn = require('child_process').spawn;
|
|
|
|
const child = spawn(process.execPath, [ '-i' ], {
|
|
stdio: [null, null, 2]
|
|
});
|
|
|
|
let stdout = '';
|
|
child.stdout.setEncoding('utf8');
|
|
child.stdout.on('data', function(c) {
|
|
process.stdout.write(c);
|
|
stdout += c;
|
|
if (stdout.includes('> THROW 2'))
|
|
child.stdin.end();
|
|
});
|
|
|
|
child.stdin.write = function(original) {
|
|
return function(c) {
|
|
process.stderr.write(c);
|
|
return original.call(child.stdin, c);
|
|
};
|
|
}(child.stdin.write);
|
|
|
|
child.stdout.once('data', function() {
|
|
child.stdin.write('var throws = 0;');
|
|
child.stdin.write('process.on("exit",function(){console.log(throws)});');
|
|
child.stdin.write('function thrower(){console.log("THROW",throws++);XXX};');
|
|
child.stdin.write('setTimeout(thrower);""\n');
|
|
|
|
setTimeout(fsTest, 50);
|
|
function fsTest() {
|
|
const f = JSON.stringify(__filename);
|
|
child.stdin.write(`fs.readFile(${f}, thrower);\n`);
|
|
setTimeout(eeTest, 50);
|
|
}
|
|
|
|
function eeTest() {
|
|
child.stdin.write('setTimeout(function() {\n' +
|
|
' const events = require("events");\n' +
|
|
' var e = new events.EventEmitter;\n' +
|
|
' process.nextTick(function() {\n' +
|
|
' e.on("x", thrower);\n' +
|
|
' setTimeout(function() {\n' +
|
|
' e.emit("x");\n' +
|
|
' });\n' +
|
|
' });\n' +
|
|
'});"";\n');
|
|
}
|
|
});
|
|
|
|
child.on('close', function(c) {
|
|
assert.strictEqual(c, 0);
|
|
// make sure we got 3 throws, in the end.
|
|
const lastLine = stdout.trim().split(/\r?\n/).pop();
|
|
assert.strictEqual(lastLine, '> 3');
|
|
});
|