0
0
mirror of https://github.com/nodejs/node.git synced 2024-11-30 07:27:22 +01:00
nodejs/benchmark
David Benjamin 6ebdb69472
crypto: fix Node_SignFinal
PR #11705 switched Node away from using using OpenSSL's legacy EVP_Sign*
and EVP_Verify* APIs. Instead, it computes a hash normally via
EVP_Digest* and then uses EVP_PKEY_sign and EVP_PKEY_verify to verify
the hash directly. This change corrects two problems:

1. The documentation still recommends the signature algorithm EVP_MD
   names of OpenSSL's legacy APIs. OpenSSL has since moved away from
   thosee, which is why ECDSA was strangely inconsistent. (This is why
   "ecdsa-with-SHA256" was missing.)

2. Node_SignFinal copied some code from EVP_SignFinal's internals. This
   is problematic for OpenSSL 1.1.0 and is missing a critical check
   that prevents pkey->pkey.ptr from being cast to the wrong type.

To resolve this, remove the non-EVP_PKEY_sign codepath. This codepath is
no longer necessary. PR #11705's verify half was already assuming all
EVP_PKEYs supported EVP_PKEY_sign and EVP_PKEY_verify. Also, in the
documentation, point users towards using hash function names which are
more consisent. This avoids an ECDSA special-case and some strangeness
around RSA-PSS ("RSA-SHA256" is the OpenSSL name of the
sha256WithRSAEncryption OID which is not used for RSA-PSS).

PR-URL: https://github.com/nodejs/node/pull/15024
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2017-09-11 00:18:02 -03:00
..
arrays benchmark: convert var to es6 const 2017-08-17 12:19:13 -04:00
assert benchmark: fix and extend assert benchmarks 2017-08-13 14:31:27 -04:00
buffers benchmark: add default configs to buffer benchmark 2017-09-07 15:47:37 -07:00
child_process tools,benchmark: use stricter indentation linting 2017-06-27 06:17:06 -07:00
cluster benchmark: remove unused parameters 2017-08-08 15:47:57 -07:00
crypto crypto: fix Node_SignFinal 2017-09-11 00:18:02 -03:00
dgram benchmark: fix dgram/bind-params.js benchmark 2017-08-23 22:34:59 -07:00
dns benchmark: fix issues in dns benchmark 2017-08-25 18:57:57 -03:00
domain
es benchmark: add benchmark for string concatenations 2017-04-20 04:47:18 +03:00
events lib,src: fix consistent spacing inside braces 2017-07-21 15:13:47 -04:00
fixtures http: always cork outgoing writes 2017-06-12 20:42:46 -04:00
fs benchmark: reduce string concatenations 2017-04-20 04:46:37 +03:00
http test: make common.PIPE process unique 2017-07-14 19:36:10 -04:00
http2 http2: set decodeStrings to false, test 2017-09-07 16:05:37 -07:00
misc test,doc: make module name match gyp target name 2017-09-10 00:15:49 +03:00
module benchmark: reduce string concatenations 2017-04-20 04:46:37 +03:00
net benchmark: reduce string concatenations 2017-04-20 04:46:37 +03:00
os
path benchmark: reduce string concatenations 2017-04-20 04:46:37 +03:00
process benchmark: cover more nextTick() code 2017-08-10 09:11:50 -07:00
querystring
streams stream: improve Transform performance 2017-06-13 11:48:53 -07:00
string_decoder
timers benchmark: remove redundant timers benchmark 2017-05-16 21:38:17 -07:00
tls benchmark: reduce string concatenations 2017-04-20 04:46:37 +03:00
url lib,src: fix consistent spacing inside braces 2017-07-21 15:13:47 -04:00
util util: improve util.inspect performance 2017-08-13 13:52:33 -04:00
v8 v8: refactor struture of v8 module 2017-04-28 14:29:45 -07:00
vm lib,src: fix consistent spacing inside braces 2017-07-21 15:13:47 -04:00
zlib zlib: improve performance 2017-06-13 11:48:59 -07:00
_benchmark_progress.js benchmark: remove unused parameters 2017-07-31 19:33:18 -07:00
_cli.js
_cli.R
_http-benchmarkers.js http2: add tests and benchmarks 2017-08-04 12:55:58 -07:00
_test-double-benchmarker.js lib,src: fix consistent spacing inside braces 2017-07-21 15:13:47 -04:00
common.js benchmark: remove needless RegExp capturing 2017-06-19 18:06:17 +03:00
compare.js tools,benchmark: use stricter indentation linting 2017-06-27 06:17:06 -07:00
compare.R
README.md http2: add tests and benchmarks 2017-08-04 12:55:58 -07:00
run.js tools,benchmark: use stricter indentation linting 2017-06-27 06:17:06 -07:00
scatter.js tools,benchmark: use stricter indentation linting 2017-06-27 06:17:06 -07:00
scatter.R

Node.js Core Benchmarks

This folder contains code and data used to measure performance of different Node.js implementations and different ways of writing JavaScript run by the built-in JavaScript engine.

For a detailed guide on how to write and run benchmarks in this directory, see the guide on benchmarks.

Table of Contents

Benchmark Directories

Directory Purpose
arrays Benchmarks for various operations on array-like objects, including Array, Buffer, and typed arrays.
assert Benchmarks for the assert subsystem.
buffers Benchmarks for the buffer subsystem.
child_process Benchmarks for the child_process subsystem.
crypto Benchmarks for the crypto subsystem.
dgram Benchmarks for the dgram subsystem.
domain Benchmarks for the domain subsystem.
es Benchmarks for various new ECMAScript features and their pre-ES2015 counterparts.
events Benchmarks for the events subsystem.
fixtures Benchmarks fixtures used in various benchmarks throughout the benchmark suite.
fs Benchmarks for the fs subsystem.
http Benchmarks for the http subsystem.
http2 Benchmarks for the http2 subsystem.
misc Miscellaneous benchmarks and benchmarks for shared internal modules.
module Benchmarks for the module subsystem.
net Benchmarks for the net subsystem.
path Benchmarks for the path subsystem.
process Benchmarks for the process subsystem.
querystring Benchmarks for the querystring subsystem.
streams Benchmarks for the streams subsystem.
string_decoder Benchmarks for the string_decoder subsystem.
timers Benchmarks for the timers subsystem, including setTimeout, setInterval, .etc.
tls Benchmarks for the tls subsystem.
url Benchmarks for the url subsystem, including the legacy url implementation and the WHATWG URL implementation.
util Benchmarks for the util subsystem.
vm Benchmarks for the vm subsystem.

Other Top-level files

The top-level files include common dependencies of the benchmarks and the tools for launching benchmarks and visualizing their output. The actual benchmark scripts should be placed in their corresponding directories.

  • _benchmark_progress.js: implements the progress bar displayed when running compare.js
  • _cli.js: parses the command line arguments passed to compare.js, run.js and scatter.js
  • _cli.R: parses the command line arguments passed to compare.R
  • _http-benchmarkers.js: selects and runs external tools for benchmarking the http subsystem.
  • common.js: see Common API.
  • compare.js: command line tool for comparing performance between different Node.js binaries.
  • compare.R: R script for statistically analyzing the output of compare.js
  • run.js: command line tool for running individual benchmark suite(s).
  • scatter.js: command line tool for comparing the performance between different parameters in benchmark configurations, for example to analyze the time complexity.
  • scatter.R: R script for visualizing the output of scatter.js with scatter plots.

Common API

The common.js module is used by benchmarks for consistency across repeated tasks. It has a number of helpful functions and properties to help with writing benchmarks.

createBenchmark(fn, configs[, options])

See the guide on writing benchmarks.

default_http_benchmarker

The default benchmarker used to run HTTP benchmarks. See the guide on writing HTTP benchmarks.

PORT

The default port used to run HTTP benchmarks. See the guide on writing HTTP benchmarks.

sendResult(data)

Used in special benchmarks that can't use createBenchmark and the object it returns to accomplish what they need. This function reports timing data to the parent process (usually created by running compare.js, run.js or scatter.js).