mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
43 lines
997 B
JavaScript
43 lines
997 B
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
const dnsPromises = require('dns').promises;
|
|
|
|
// Error when rrtype is invalid.
|
|
{
|
|
const rrtype = 'DUMMY';
|
|
assert.throws(
|
|
() => dnsPromises.resolve('example.org', rrtype),
|
|
{
|
|
code: 'ERR_INVALID_OPT_VALUE',
|
|
name: 'TypeError',
|
|
message: `The value "${rrtype}" is invalid for option "rrtype"`
|
|
}
|
|
);
|
|
}
|
|
|
|
// Error when rrtype is a number.
|
|
{
|
|
const rrtype = 0;
|
|
assert.throws(
|
|
() => dnsPromises.resolve('example.org', rrtype),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "rrtype" argument must be of type string. ' +
|
|
`Received type ${typeof rrtype} (${rrtype})`
|
|
}
|
|
);
|
|
}
|
|
|
|
// Setting rrtype to undefined should work like resolve4.
|
|
{
|
|
(async function() {
|
|
const rrtype = undefined;
|
|
const result = await dnsPromises.resolve('example.org', rrtype);
|
|
assert.ok(result !== undefined);
|
|
assert.ok(result.length > 0);
|
|
})();
|
|
}
|