mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
f21cf456bf
Currently, the following warnings are emitted during compilation:
In file included from ../src/string_bytes.h:29,
from ../src/string_bytes.cc:22:
../deps/v8/include/v8.h:
In instantiation of ‘void v8::PersistentBase<T>::SetWeak(
P*,typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType)
[with P = node::BaseObject;
T = v8::Object;
typename v8::WeakCallbackInfo<P>::Callback =
void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)]’:
../src/base_object-inl.h:135:42: required from here
../deps/v8/include/v8.h:10732:16: warning:
cast between incompatible function types from
‘v8::WeakCallbackInfo<node::BaseObject>::Callback’ {aka
‘void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)’} to
‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’}
[-Wcast-function-type]
10732 | reinterpret_cast<Callback>(callback), type);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
And the same from test/cctest/test_aliased_buffer.cc
We have an open pull request against v8 for this:
https://chromium-review.googlesource.com/c/v8/v8/+/2080361
PR-URL: https://github.com/nodejs/node/pull/32679
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
|
||
|---|---|---|
| .. | ||
| gtest | ||
| node_test_fixture.cc | ||
| node_test_fixture.h | ||
| test_aliased_buffer.cc | ||
| test_base64.cc | ||
| test_base_object_ptr.cc | ||
| test_environment.cc | ||
| test_inspector_socket_server.cc | ||
| test_inspector_socket.cc | ||
| test_json_utils.cc | ||
| test_linked_binding.cc | ||
| test_node_postmortem_metadata.cc | ||
| test_per_process.cc | ||
| test_platform.cc | ||
| test_sockaddr.cc | ||
| test_traced_value.cc | ||
| test_url.cc | ||
| test_util.cc | ||