mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
68aa129ac1
Original commit message:
[promise] Implement Swallowed Rejection Hook.
This extends the current Promise Rejection Hook with two new events
kPromiseRejectAfterResolved
kPromiseResolveAfterResolved
which are used to detect (and signal) misuse of the Promise constructor.
Specifically the common bug like
new Promise((res, rej) => {
res(1);
throw new Error("something")
});
where the error is silently swallowed by the Promise constructor without
the user ever noticing can be caught via this hook.
Doc: https://goo.gl/2stLUY
Bug: v8:7919
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I890a7e766cdd1be88db94844fb744f72823dba33
Reviewed-on: https://chromium-review.googlesource.com/1126099
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54309}
Refs:
|
||
|---|---|---|
| .. | ||
| libplatform | ||
| APIDesign.md | ||
| DEPS | ||
| OWNERS | ||
| PRESUBMIT.py | ||
| v8-inspector-protocol.h | ||
| v8-inspector.h | ||
| v8-platform.h | ||
| v8-profiler.h | ||
| v8-testing.h | ||
| v8-util.h | ||
| v8-value-serializer-version.h | ||
| v8-version-string.h | ||
| v8-version.h | ||
| v8.h | ||
| v8config.h | ||