mirror of
https://github.com/nodejs/node.git
synced 2024-11-30 15:30:56 +01:00
c72e540cde
Remove request that user provide a list of subsystems in the pull request template. * We already ask them to put the subsystems in the first line of the commit message. * The subsystem is usually easy to determine. * We have a bot that applies subsystem labels on new PRs and it seems to do a rather good job. Tools over rules. Let the bot do it. * The fewer unnecessary things we ask for in the template, the lower the barrier to entry. * Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post. PR-URL: https://github.com/nodejs/node/pull/19125 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
17 lines
673 B
Markdown
17 lines
673 B
Markdown
<!--
|
|
Thank you for your pull request. Please provide a description above and review
|
|
the requirements below.
|
|
|
|
Bug fixes and new features should include tests and possibly benchmarks.
|
|
|
|
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
|
|
-->
|
|
|
|
##### Checklist
|
|
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
|
|
|
|
- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes
|
|
- [ ] tests and/or benchmarks are included
|
|
- [ ] documentation is changed or added
|
|
- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)
|