mirror of
https://github.com/nodejs/node.git
synced 2024-11-24 20:29:23 +01:00
5774688e26
Overriding `require('http[s]').globalAgent` is now respected by
consequent requests.
In order to achieve that, the following changes were made:
1. Implmentation in `http`: `module.exports.globalAgent` is now defined
through `Object.defineProperty`. Its getter and setter return \ set
`require('_http_agent').globalAgent`.
2. Implementation in `https`: the https `globalAgent` is not the same
as `_http_agent`, and is defined in `https` module itself. Therefore,
the fix here was to simply use `module.exports.globalAgent` to support
mutation.
3. According tests were added for both `http` and `https`, where in
both we create a server, set the default agent to a newly created
instance and make a request to that server. We then assert that the
given instance was actually used by inspecting its sockets property.
Fixes: https://github.com/nodejs/node/issues/23281
PR-URL: https://github.com/nodejs/node/pull/25170
Reviewed-By: James M Snell <jasnell@gmail.com>
89 lines
2.5 KiB
JavaScript
89 lines
2.5 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
|
|
const httpAgent = require('_http_agent');
|
|
const { ClientRequest } = require('_http_client');
|
|
const { methods } = require('_http_common');
|
|
const { IncomingMessage } = require('_http_incoming');
|
|
const { OutgoingMessage } = require('_http_outgoing');
|
|
const {
|
|
_connectionListener,
|
|
STATUS_CODES,
|
|
Server,
|
|
ServerResponse
|
|
} = require('_http_server');
|
|
let maxHeaderSize;
|
|
|
|
function createServer(opts, requestListener) {
|
|
return new Server(opts, requestListener);
|
|
}
|
|
|
|
function request(url, options, cb) {
|
|
return new ClientRequest(url, options, cb);
|
|
}
|
|
|
|
function get(url, options, cb) {
|
|
var req = request(url, options, cb);
|
|
req.end();
|
|
return req;
|
|
}
|
|
|
|
module.exports = {
|
|
_connectionListener,
|
|
METHODS: methods.slice().sort(),
|
|
STATUS_CODES,
|
|
Agent: httpAgent.Agent,
|
|
ClientRequest,
|
|
IncomingMessage,
|
|
OutgoingMessage,
|
|
Server,
|
|
ServerResponse,
|
|
createServer,
|
|
get,
|
|
request
|
|
};
|
|
|
|
Object.defineProperty(module.exports, 'maxHeaderSize', {
|
|
configurable: true,
|
|
enumerable: true,
|
|
get() {
|
|
if (maxHeaderSize === undefined) {
|
|
const { getOptionValue } = require('internal/options');
|
|
maxHeaderSize = getOptionValue('--max-http-header-size');
|
|
}
|
|
|
|
return maxHeaderSize;
|
|
}
|
|
});
|
|
|
|
Object.defineProperty(module.exports, 'globalAgent', {
|
|
configurable: true,
|
|
enumerable: true,
|
|
get() {
|
|
return httpAgent.globalAgent;
|
|
},
|
|
set(value) {
|
|
httpAgent.globalAgent = value;
|
|
}
|
|
});
|