mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
4e6dc00401
There has been occasional nits for spacing in object literals in PRs but
the project does not lint for it and it is not always handled
consistently in the existing code, even on adjacent lines of a file.
This change enables a linting rule requiring no space between the key
and the colon, and requiring at least one space (but allowing for more
so property values can be lined up if desired) between the colon and the
value. This appears to be the most common style used in the current code
base.
Example code the complies with lint rule:
myObj = { foo: 'bar' };
Examples that do not comply with the lint rule:
myObj = { foo : 'bar' };
myObj = { foo:'bar' };
PR-URL: https://github.com/nodejs/node/pull/6592
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
68 lines
1.9 KiB
JavaScript
68 lines
1.9 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var http = require('http');
|
|
|
|
var outstanding_reqs = 0;
|
|
var test_req_body = 'some stuff...\n';
|
|
var test_res_body = 'other stuff!\n';
|
|
var sent_continue = false;
|
|
var got_continue = false;
|
|
|
|
function handler(req, res) {
|
|
assert.equal(sent_continue, true, 'Full response sent before 100 Continue');
|
|
console.error('Server sending full response...');
|
|
res.writeHead(200, {
|
|
'Content-Type': 'text/plain',
|
|
'ABCD': '1'
|
|
});
|
|
res.end(test_res_body);
|
|
}
|
|
|
|
var server = http.createServer(handler);
|
|
server.on('checkContinue', function(req, res) {
|
|
console.error('Server got Expect: 100-continue...');
|
|
res.writeContinue();
|
|
sent_continue = true;
|
|
setTimeout(function() {
|
|
handler(req, res);
|
|
}, 100);
|
|
});
|
|
server.listen(common.PORT);
|
|
|
|
|
|
server.on('listening', function() {
|
|
var req = http.request({
|
|
port: common.PORT,
|
|
method: 'POST',
|
|
path: '/world',
|
|
headers: { 'Expect': '100-continue' }
|
|
});
|
|
console.error('Client sending request...');
|
|
outstanding_reqs++;
|
|
var body = '';
|
|
req.on('continue', function() {
|
|
console.error('Client got 100 Continue...');
|
|
got_continue = true;
|
|
req.end(test_req_body);
|
|
});
|
|
req.on('response', function(res) {
|
|
assert.equal(got_continue, true,
|
|
'Full response received before 100 Continue');
|
|
assert.equal(200, res.statusCode,
|
|
'Final status code was ' + res.statusCode + ', not 200.');
|
|
res.setEncoding('utf8');
|
|
res.on('data', function(chunk) { body += chunk; });
|
|
res.on('end', function() {
|
|
console.error('Got full response.');
|
|
assert.equal(body, test_res_body, 'Response body doesn\'t match.');
|
|
assert.ok('abcd' in res.headers, 'Response headers missing.');
|
|
outstanding_reqs--;
|
|
if (outstanding_reqs == 0) {
|
|
server.close();
|
|
process.exit();
|
|
}
|
|
});
|
|
});
|
|
});
|