mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
7535a94c8a
Adds a new `../common/fixtures' module to begin normalizing `test/fixtures` use. Our test code is a bit inconsistent with regards to use of the fixtures directory. Some code uses `path.join()`, some code uses string concats, some other code uses template strings, etc. In mnay cases, significant duplication of code is seen when accessing fixture files, etc. This updates many (but by no means all) of the tests in the test suite to use the new consistent API. There are still many more to update, which would make an excelent Code-n-Learn exercise. PR-URL: https://github.com/nodejs/node/pull/14332 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
61 lines
1.9 KiB
JavaScript
61 lines
1.9 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const fs = require('fs');
|
|
const rl = require('readline');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const BOM = '\uFEFF';
|
|
|
|
// Get the data using a non-stream way to compare with the streamed data.
|
|
const modelData = fixtures.readSync('file-to-read-without-bom.txt', 'utf8');
|
|
const modelDataFirstCharacter = modelData[0];
|
|
|
|
// Detect the number of forthcoming 'line' events for mustCall() 'expected' arg.
|
|
const lineCount = modelData.match(/\n/g).length;
|
|
|
|
// Ensure both without-bom and with-bom test files are textwise equal.
|
|
assert.strictEqual(fixtures.readSync('file-to-read-with-bom.txt', 'utf8'),
|
|
`${BOM}${modelData}`
|
|
);
|
|
|
|
// An unjustified BOM stripping with a non-BOM character unshifted to a stream.
|
|
const inputWithoutBOM =
|
|
fs.createReadStream(fixtures.path('file-to-read-without-bom.txt'), 'utf8');
|
|
|
|
inputWithoutBOM.once('readable', common.mustCall(() => {
|
|
const maybeBOM = inputWithoutBOM.read(1);
|
|
assert.strictEqual(maybeBOM, modelDataFirstCharacter);
|
|
assert.notStrictEqual(maybeBOM, BOM);
|
|
|
|
inputWithoutBOM.unshift(maybeBOM);
|
|
|
|
let streamedData = '';
|
|
rl.createInterface({
|
|
input: inputWithoutBOM,
|
|
}).on('line', common.mustCall((line) => {
|
|
streamedData += `${line}\n`;
|
|
}, lineCount)).on('close', common.mustCall(() => {
|
|
assert.strictEqual(streamedData, modelData);
|
|
}));
|
|
}));
|
|
|
|
// A justified BOM stripping.
|
|
const inputWithBOM =
|
|
fs.createReadStream(fixtures.path('file-to-read-with-bom.txt'), 'utf8');
|
|
|
|
inputWithBOM.once('readable', common.mustCall(() => {
|
|
const maybeBOM = inputWithBOM.read(1);
|
|
assert.strictEqual(maybeBOM, BOM);
|
|
|
|
let streamedData = '';
|
|
rl.createInterface({
|
|
input: inputWithBOM,
|
|
}).on('line', common.mustCall((line) => {
|
|
streamedData += `${line}\n`;
|
|
}, lineCount)).on('close', common.mustCall(() => {
|
|
assert.strictEqual(streamedData, modelData);
|
|
}));
|
|
}));
|