mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
2da7d9b820
Extensive re-work of http1 compatibility layer based on tests in express, on-finished and finalhandler. Fix handling of HEAD method to match http1. Adjust write, end, etc. to call writeHead as in http1 and as expected by user-land modules. Add socket proxy that instead uses the Http2Stream for the vast majority of socket interactions. Add and change tests to closer represent http1 behaviour. Refs: https://github.com/nodejs/node/pull/15633 Refs: https://github.com/expressjs/express/tree/master/test Refs: https://github.com/jshttp/on-finished/blob/master/test/test.js Refs: https://github.com/pillarjs/finalhandler/blob/master/test/test.js PR-URL: https://github.com/nodejs/node/pull/15702 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
93 lines
2.1 KiB
JavaScript
93 lines
2.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
|
|
// Check that destroying the Http2ServerResponse stream produces
|
|
// the expected result, including the ability to throw an error
|
|
// which is emitted on server.streamError
|
|
|
|
const errors = [
|
|
'test-error',
|
|
Error('test')
|
|
];
|
|
let nextError;
|
|
|
|
const server = http2.createServer(common.mustCall((req, res) => {
|
|
req.on('error', common.mustNotCall());
|
|
res.on('error', common.mustNotCall());
|
|
|
|
res.on('finish', common.mustCall(() => {
|
|
assert.doesNotThrow(() => res.destroy(nextError));
|
|
process.nextTick(() => {
|
|
assert.doesNotThrow(() => res.destroy(nextError));
|
|
});
|
|
}));
|
|
|
|
if (req.url !== '/') {
|
|
nextError = errors.shift();
|
|
}
|
|
res.destroy(nextError);
|
|
}, 3));
|
|
|
|
server.on(
|
|
'streamError',
|
|
common.mustCall((err) => assert.strictEqual(err, nextError), 2)
|
|
);
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const port = server.address().port;
|
|
const client = http2.connect(`http://localhost:${port}`);
|
|
const req = client.request({
|
|
':path': '/',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`
|
|
});
|
|
|
|
req.on('response', common.mustNotCall());
|
|
req.on('error', common.mustNotCall());
|
|
req.on('end', common.mustCall());
|
|
|
|
req.resume();
|
|
req.end();
|
|
|
|
const req2 = client.request({
|
|
':path': '/error',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`
|
|
});
|
|
|
|
req2.on('response', common.mustNotCall());
|
|
req2.on('error', common.mustNotCall());
|
|
req2.on('end', common.mustCall());
|
|
|
|
req2.resume();
|
|
req2.end();
|
|
|
|
const req3 = client.request({
|
|
':path': '/error',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`
|
|
});
|
|
|
|
req3.on('response', common.mustNotCall());
|
|
req3.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_STREAM_ERROR',
|
|
type: Error,
|
|
message: 'Stream closed with error code 2'
|
|
}));
|
|
req3.on('end', common.mustCall(() => {
|
|
server.close();
|
|
client.destroy();
|
|
}));
|
|
|
|
req3.resume();
|
|
req3.end();
|
|
}));
|