mirror of
https://github.com/nodejs/node.git
synced 2024-11-30 15:30:56 +01:00
c11612026f
Don't emit a 'connect' event on sockets that are handed off to net.Server 'connection' event listeners. 1. It's superfluous because the connection has already been established at that point. 2. The implementation is arguably wrong because the event is emitted on the same tick of the event loop while the rule of thumb is to always emit it on the next one. This has been tried before in commitf0a440dbut was reverted again inede1accbecause the change was incomplete (at least one test hadn't been updated). Fixes #1047 (again).
85 lines
2.5 KiB
JavaScript
85 lines
2.5 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
|
|
|
|
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var net = require('net');
|
|
|
|
var N = 1024 * 1024;
|
|
var part_N = N / 3;
|
|
var chars_recved = 0;
|
|
var npauses = 0;
|
|
|
|
console.log('build big string');
|
|
var body = '';
|
|
for (var i = 0; i < N; i++) {
|
|
body += 'C';
|
|
}
|
|
|
|
console.log('start server on port ' + common.PORT);
|
|
|
|
var server = net.createServer(function(connection) {
|
|
connection.write(body.slice(0, part_N));
|
|
connection.write(body.slice(part_N, 2 * part_N));
|
|
assert.equal(false, connection.write(body.slice(2 * part_N, N)));
|
|
console.log('bufferSize: ' + connection.bufferSize);
|
|
assert.ok(0 <= connection.bufferSize && connection.bufferSize <= N);
|
|
connection.end();
|
|
});
|
|
|
|
server.listen(common.PORT, function() {
|
|
var paused = false;
|
|
var client = net.createConnection(common.PORT);
|
|
client.setEncoding('ascii');
|
|
client.on('data', function(d) {
|
|
chars_recved += d.length;
|
|
console.log('got ' + chars_recved);
|
|
if (!paused) {
|
|
client.pause();
|
|
npauses += 1;
|
|
paused = true;
|
|
console.log('pause');
|
|
var x = chars_recved;
|
|
setTimeout(function() {
|
|
assert.equal(chars_recved, x);
|
|
client.resume();
|
|
console.log('resume');
|
|
paused = false;
|
|
}, 100);
|
|
}
|
|
});
|
|
|
|
client.on('end', function() {
|
|
server.close();
|
|
client.end();
|
|
});
|
|
});
|
|
|
|
|
|
|
|
process.on('exit', function() {
|
|
assert.equal(N, chars_recved);
|
|
assert.equal(true, npauses > 2);
|
|
});
|