mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
9fd22bc4d4
Currently the files specified in libraries in node.gyp `cctest` target are getting a '.lib' extension on windows when generated with ninja. This commit adds a check to see if a file has a '.obj' extension and in that case no '.lib' extension will be added. Also, the LIBS specified in the 'libraries' section are not being included in the --start-group --end-group section which means that these libraries will not be searched causing issue with linkers where the order matters. PR-URL: https://github.com/nodejs/node/pull/12484 Fixes: https://github.com/nodejs/node/issues/12448 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> |
||
|---|---|---|
| .. | ||
| buildbot | ||
| data/win | ||
| pylib/gyp | ||
| samples | ||
| tools | ||
| .gitignore | ||
| AUTHORS | ||
| codereview.settings | ||
| DEPS | ||
| gyp | ||
| gyp_main.py | ||
| gyp.bat | ||
| gyptest.py | ||
| LICENSE | ||
| OWNERS | ||
| PRESUBMIT.py | ||
| README.md | ||
| setup.py | ||
GYP can Generate Your Projects.
Documents are available at gyp.gsrc.io, or you can check out md-pages branch to read those documents offline.