mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
88644eaa2d
This makes it so that `stream.push(chunk)` is the only way to signal the
end of reading, removing the confusing disparity between the
callback-style _read method, and the fact that most real-world streams
do not have a 1:1 corollation between the "please give me data" event,
and the actual arrival of a chunk of data.
It is still possible, of course, to implement a `CallbackReadable` on
top of this. Simply provide a method like this as the callback:
function readCallback(er, chunk) {
if (er)
stream.emit('error', er);
else
stream.push(chunk);
}
However, *only* fs streams actually would behave in this way, so it
makes not a lot of sense to make TCP, TLS, HTTP, and all the rest have
to bend into this uncomfortable paradigm.
55 lines
1.8 KiB
JavaScript
55 lines
1.8 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var Readable = require('stream').Readable;
|
|
var r = new Readable();
|
|
var N = 256 * 1024;
|
|
|
|
// Go ahead and allow the pathological case for this test.
|
|
// Yes, it's an infinite loop, that's the point.
|
|
process.maxTickDepth = N + 2;
|
|
|
|
var reads = 0;
|
|
r._read = function(n) {
|
|
var chunk = reads++ === N ? null : new Buffer(1);
|
|
r.push(chunk);
|
|
};
|
|
|
|
r.on('readable', function onReadable() {
|
|
if (!(r._readableState.length % 256))
|
|
console.error('readable', r._readableState.length);
|
|
r.read(N * 2);
|
|
});
|
|
|
|
var ended = false;
|
|
r.on('end', function onEnd() {
|
|
ended = true;
|
|
});
|
|
|
|
r.read(0);
|
|
|
|
process.on('exit', function() {
|
|
assert(ended);
|
|
console.log('ok');
|
|
});
|