mirror of
https://github.com/nodejs/node.git
synced 2024-11-30 23:43:09 +01:00
42c14c5c17
This commit set the Environment as a thread local when CreateEnvironment is called which is currently not being done. This would lead to a segment fault if later node::AtExit is called without specifying the environment parameter. This specific issue was reported by Electron. If I recall correctly, back when this was implemented the motivation was that if embedders have multiple environments per isolate they should be using the AtExit functions that take an environment. This is not the case with Electron which only create a single environment (as far as I know), and if a native module calls AtExit this would lead to the segment fault. I was able to reproduce Electron issue and the provided test simulates it. I was also able to use this patch and verify that it works for the Electron issue as well. PR-URL: https://github.com/nodejs/node/pull/18573 Refs: https://github.com/nodejs/node/pull/9163 Refs: https://github.com/electron/electron/issues/11299 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matheus Marchini <matheus@sthima.com> |
||
|---|---|---|
| .. | ||
| node_module_reg.cc | ||
| node_test_fixture.cc | ||
| node_test_fixture.h | ||
| test_aliased_buffer.cc | ||
| test_base64.cc | ||
| test_environment.cc | ||
| test_inspector_socket_server.cc | ||
| test_inspector_socket.cc | ||
| test_node_postmortem_metadata.cc | ||
| test_url.cc | ||
| test_util.cc | ||