mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
676e61872f
The assert.fail function signature has the message as the third argument
but, understandably, it is often assumed that it is the first argument
(or at least the first argument if no other arguments are passed).
This corrects the assert.fail() invocations in the Node.js tests.
Before:
assert.fail('message');
// result: AssertionError: 'message' undefined undefined
After:
assert.fail(null, null, 'message');
// result: AssertionError: message
PR-URL: https://github.com/nodejs/node/pull/3378
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
48 lines
1011 B
JavaScript
48 lines
1011 B
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var net = require('net');
|
|
|
|
var SIZE = 2E5;
|
|
var N = 10;
|
|
var flushed = 0;
|
|
var received = 0;
|
|
var buf = new Buffer(SIZE);
|
|
buf.fill(0x61); // 'a'
|
|
|
|
var server = net.createServer(function(socket) {
|
|
socket.setNoDelay();
|
|
socket.setTimeout(1000);
|
|
socket.on('timeout', function() {
|
|
assert.fail(null, null, 'flushed: ' + flushed +
|
|
', received: ' + received + '/' + SIZE * N);
|
|
});
|
|
|
|
for (var i = 0; i < N; ++i) {
|
|
socket.write(buf, function() {
|
|
++flushed;
|
|
if (flushed === N) {
|
|
socket.setTimeout(0);
|
|
}
|
|
});
|
|
}
|
|
socket.end();
|
|
|
|
}).listen(common.PORT, function() {
|
|
var conn = net.connect(common.PORT);
|
|
conn.on('data', function(buf) {
|
|
received += buf.length;
|
|
conn.pause();
|
|
setTimeout(function() {
|
|
conn.resume();
|
|
}, 20);
|
|
});
|
|
conn.on('end', function() {
|
|
server.close();
|
|
});
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
assert.equal(received, SIZE * N);
|
|
});
|