mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
676e61872f
The assert.fail function signature has the message as the third argument
but, understandably, it is often assumed that it is the first argument
(or at least the first argument if no other arguments are passed).
This corrects the assert.fail() invocations in the Node.js tests.
Before:
assert.fail('message');
// result: AssertionError: 'message' undefined undefined
After:
assert.fail(null, null, 'message');
// result: AssertionError: message
PR-URL: https://github.com/nodejs/node/pull/3378
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
33 lines
719 B
JavaScript
33 lines
719 B
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
var path = require('path'),
|
|
fs = require('fs');
|
|
|
|
var file = path.join(common.tmpDir, 'write.txt');
|
|
|
|
common.refreshTmpDir();
|
|
|
|
(function() {
|
|
var stream = fs.WriteStream(file),
|
|
_fs_close = fs.close;
|
|
|
|
fs.close = function(fd) {
|
|
assert.ok(fd, 'fs.close must not be called without an undefined fd.');
|
|
fs.close = _fs_close;
|
|
};
|
|
stream.destroy();
|
|
})();
|
|
|
|
(function() {
|
|
var stream = fs.createWriteStream(file);
|
|
|
|
stream.on('drain', function() {
|
|
assert.fail(null, null, '\'drain\' event must not be emitted before ' +
|
|
'stream.write() has been called at least once.');
|
|
});
|
|
stream.destroy();
|
|
})();
|
|
|